Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: chrome/browser/extensions/extensions_service_unittest.cc

Issue 1120006: detect preferences errors (Closed)
Patch Set: changes from review Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_service_unittest.cc
diff --git a/chrome/browser/extensions/extensions_service_unittest.cc b/chrome/browser/extensions/extensions_service_unittest.cc
index 38932c95f9409b6435bf414db2e0e798c9c983e2..9888e8fce8a638f3501db7f54613906f93334911 100644
--- a/chrome/browser/extensions/extensions_service_unittest.cc
+++ b/chrome/browser/extensions/extensions_service_unittest.cc
@@ -150,11 +150,9 @@ class MockProviderVisitor : public ExternalExtensionProvider::Visitor {
// We also parse the file into a dictionary to compare what we get back
// from the provider.
JSONStringValueSerializer serializer(json_data);
- std::string error_msg;
- Value* json_value = serializer.Deserialize(&error_msg);
+ Value* json_value = serializer.Deserialize(NULL, NULL);
- if (!error_msg.empty() || !json_value ||
- !json_value->IsType(Value::TYPE_DICTIONARY)) {
+ if (!json_value || !json_value->IsType(Value::TYPE_DICTIONARY)) {
NOTREACHED() << L"Unable to deserialize json data";
return -1;
} else {
« no previous file with comments | « chrome/browser/extensions/extensions_service.cc ('k') | chrome/browser/extensions/external_pref_extension_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698