chrome/browser/browser_theme_pack_unittest.cc - Issue 1120006: detect preferences errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_theme_pack_unittest.cc

Issue 1120006: detect preferences errors (Closed)

Patch Set: changes from review Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_theme_pack_unittest.cc

diff --git a/chrome/browser/browser_theme_pack_unittest.cc b/chrome/browser/browser_theme_pack_unittest.cc

index 1a05582956378845bb73d66fac3ca3ff8df89227..0b7912f777696a21690f493f854eafe47fce2d9e 100644

--- a/chrome/browser/browser_theme_pack_unittest.cc

+++ b/chrome/browser/browser_theme_pack_unittest.cc

@@ -406,7 +406,7 @@ TEST_F(BrowserThemePackTest, CanBuildAndReadPack) {

std::string error;

JSONFileValueSerializer serializer(manifest_path);

scoped_ptr<DictionaryValue> valid_value(

- static_cast<DictionaryValue*>(serializer.Deserialize(&error)));

+ static_cast<DictionaryValue*>(serializer.Deserialize(NULL, &error)));

EXPECT_EQ("", error);

ASSERT_TRUE(valid_value.get());

ASSERT_TRUE(extension.InitFromValue(*valid_value, true, &error));