Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 1120006: detect preferences errors (Closed)
Patch Set: changes from review Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/search_provider.cc ('k') | chrome/browser/bookmarks/bookmark_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/automation_provider.cc
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc
index 2b88a29d982a908505cc5d0ea36f6093f20ccade..d137e8c0716e258874f4a4900f2330a42eaa5818 100644
--- a/chrome/browser/automation/automation_provider.cc
+++ b/chrome/browser/automation/automation_provider.cc
@@ -1558,7 +1558,7 @@ void AutomationProvider::SendJSONRequest(
} else {
base::JSONReader reader;
std::string error;
- values.reset(reader.ReadAndReturnError(json_request, true, &error));
+ values.reset(reader.ReadAndReturnError(json_request, true, NULL, &error));
if (!error.empty()) {
error_string = error;
}
@@ -1641,11 +1641,11 @@ class SetProxyConfigTask : public Task {
virtual void Run() {
// First, deserialize the JSON string. If this fails, log and bail.
JSONStringValueSerializer deserializer(proxy_config_);
- std::string error_message;
- scoped_ptr<Value> root(deserializer.Deserialize(&error_message));
+ std::string error_msg;
+ scoped_ptr<Value> root(deserializer.Deserialize(NULL, &error_msg));
if (!root.get() || root->GetType() != Value::TYPE_DICTIONARY) {
DLOG(WARNING) << "Received bad JSON string for ProxyConfig: "
- << error_message;
+ << error_msg;
return;
}
« no previous file with comments | « chrome/browser/autocomplete/search_provider.cc ('k') | chrome/browser/bookmarks/bookmark_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698