chrome/browser/autofill/autocomplete_history_manager.cc - Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autocomplete_history_manager.cc

Issue 11198048: [Autofill] Update the autocomplete types implementation to match the current HTML spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: string16 -> std::string and other fixes + cleanup Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/address_field_unittest.cc ('k') | chrome/browser/autofill/autocomplete_history_manager_unittest.cc » ('j') | chrome/browser/autofill/form_structure.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autocomplete_history_manager.cc

diff --git a/chrome/browser/autofill/autocomplete_history_manager.cc b/chrome/browser/autofill/autocomplete_history_manager.cc

index 4cee49385bb3bb919f3649564c9afe8c8a4cf34e..4678f831e8d27b4f8575ca967f0409b7c3ed2a5f 100644

--- a/chrome/browser/autofill/autocomplete_history_manager.cc

+++ b/chrome/browser/autofill/autocomplete_history_manager.cc

@@ -98,12 +98,12 @@ bool IsSSN(const string16& text) {

bool IsTextField(const FormFieldData& field) {

return

- field.form_control_type == ASCIIToUTF16("text") ||

- field.form_control_type == ASCIIToUTF16("search") ||

- field.form_control_type == ASCIIToUTF16("tel") ||

- field.form_control_type == ASCIIToUTF16("url") ||

- field.form_control_type == ASCIIToUTF16("email") ||

- field.form_control_type == ASCIIToUTF16("text");

+ field.form_control_type == "text" ||

+ field.form_control_type == "search" ||

+ field.form_control_type == "tel" ||

+ field.form_control_type == "url" ||

+ field.form_control_type == "email" ||

+ field.form_control_type == "text";

}

} // namespace