Make tab capture media stream requests verify that the request came from extension API

chrome/common/extensions/request_media_access_permission_helper.cc

Index: chrome/common/extensions/request_media_access_permission_helper.cc
diff --git a/chrome/common/extensions/request_media_access_permission_helper.cc b/chrome/common/extensions/request_media_access_permission_helper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c0c671d7b091c52a3d64ab828cd5a68b02577d20
--- /dev/null
+++ b/chrome/common/extensions/request_media_access_permission_helper.cc
@@ -0,0 +1,44 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/extensions/request_media_access_permission_helper.h"
+
+namespace extensions {
+
+// static
+void RequestMediaAccessPermissionHelper::AuthorizeRequest(
+    const content::MediaStreamRequest* request,

[no longer working on chromium, 2012/10/19 14:40:54]

Are you sure the request won't be deleted before it quits the function?

[justinlin, 2012/10/19 18:02:01]

Do you mean I should make a copy? I don't think I see any problem with it
getting deleted since none of the calling functions or original code expect it
to be deleted during authorization.

+    const content::MediaResponseCallback& callback,
+    bool allow_audio,
+    bool allow_video,
+    bool allow_tab_media) {

[no longer working on chromium, 2012/10/19 14:40:54]

why do you need an extra allow_tab_media? reuse the allow_audio should be enough
for you.

[justinlin, 2012/10/19 18:02:01]

Trying to preserve the existing functionality. In shell_window.cc (platform
apps), they require kAudioCapture and kVideoCapture permissions to access webcam
and mic (in extensions we didn't require that). For tab audio/video, we require
the kTabCapture permission for both platform_apps/extensions. I don't think we
need separate tab_audio/tab_video permissions because it's really always the
same "device".

Also, on second thought, since I didn't work before to get webcam/mic from an
extension, we should probably just keep it disabled. Made that change.

+  content::MediaStreamDevices devices;
+
+  bool accepted_an_audio_device = false;
+  bool accepted_a_video_device = false;
+  for (content::MediaStreamDeviceMap::const_iterator it =
+       request->devices.begin(); it != request->devices.end(); ++it) {
+    if (!accepted_an_audio_device &&
+        content::IsAudioMediaType(it->first) &&
+        !it->second.empty() &&
+        ((it->first == content::MEDIA_DEVICE_AUDIO_CAPTURE && allow_audio) ||
+         (it->first == content::MEDIA_TAB_AUDIO_CAPTURE && allow_tab_media))) {
+      devices.push_back(it->second.front());
+      accepted_an_audio_device = true;
+    } else if (!accepted_a_video_device &&
+               content::IsVideoMediaType(it->first) &&
+               !it->second.empty() &&
+               ((it->first == content::MEDIA_DEVICE_VIDEO_CAPTURE &&
+                 allow_video) ||
+                (it->first == content::MEDIA_TAB_VIDEO_CAPTURE &&
+                 allow_tab_media))) {
+      devices.push_back(it->second.front());
+      accepted_a_video_device = true;
+    }
+  }
+
+  callback.Run(devices);
+}
+
+}  // namespace extensions