Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/android/network_library.cc

Issue 11198029: Android: remove check for JNI method id. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/android/network_library.cc
diff --git a/net/android/network_library.cc b/net/android/network_library.cc
index ce5567928b4b4a8110ecc643f4b9e14e9d5cf67f..5cc47eb2bcea30142bad66230c2e0dd177425af2 100644
--- a/net/android/network_library.cc
+++ b/net/android/network_library.cc
@@ -26,8 +26,7 @@ namespace android {
VerifyResult VerifyX509CertChain(const std::vector<std::string>& cert_chain,
const std::string& auth_type) {
JNIEnv* env = AttachCurrentThread();
- if (!env || !g_AndroidNetworkLibrary_verifyServerCertificates) {
- // TODO(bulach): Remove when we initialize the JVM in unit tests.
+ if (!env) {
LOG(WARNING) << "JNI initialization failed";
return VERIFY_INVOCATION_ERROR;
}
joth 2012/10/17 20:46:19 you can remove the entire if() block, as AttachCur
bulach 2012/10/18 08:46:59 Done.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698