chrome/chrome_browser.gypi - Issue 11195010: Extract Favicon Download logic from FaviconTabHelper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 11195010: Extract Favicon Download logic from FaviconTabHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reviewer comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index db90b0c1de647d29e1013f9b7b69670787babf03..09692c848d20d7db91ae91d12b8e86363f6e905f 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -613,6 +613,9 @@

'browser/external_protocol/external_protocol_observer.cc',

'browser/external_protocol/external_protocol_observer.h',

'browser/external_tab/external_tab_container.h',

+ 'browser/favicon/favicon_download_helper.cc',

+ 'browser/favicon/favicon_download_helper.h',

+ 'browser/favicon/favicon_download_helper_delegate.h',

'browser/favicon/favicon_handler.cc',

'browser/favicon/favicon_handler.h',

'browser/favicon/favicon_handler_delegate.h',