Extract Favicon Download logic from FaviconTabHelper

chrome/browser/ui/tab_contents/tab_contents.cc

Index: chrome/browser/ui/tab_contents/tab_contents.cc
diff --git a/chrome/browser/ui/tab_contents/tab_contents.cc b/chrome/browser/ui/tab_contents/tab_contents.cc
index b630b9280404db8f4398162a93ee84c01923d146..5c6904f0f34c1ddbc7408c1dc4c0a6182837b0df 100644
--- a/chrome/browser/ui/tab_contents/tab_contents.cc
+++ b/chrome/browser/ui/tab_contents/tab_contents.cc
@@ -13,6 +13,7 @@
 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/external_protocol/external_protocol_observer.h"
+#include "chrome/browser/favicon/favicon_download_helper.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/history/history_tab_helper.h"
 #include "chrome/browser/infobars/infobar_tab_helper.h"
@@ -131,6 +132,8 @@ TabContents::TabContents(WebContents* contents)
   extensions::WebNavigationTabObserver::CreateForWebContents(contents);
   ExternalProtocolObserver::CreateForWebContents(contents);
   FaviconTabHelper::CreateForWebContents(contents);
+  FaviconDownloadHelper::CreateForWebContentsAndDelegate(contents,
+      FaviconTabHelper::FromWebContents(contents));

[sky, 2012/10/24 16:38:10]

Doesn't doing this lead to the possibility of FaviconTabHelper being destroyed
before FaviconDownloadHelper?

[Cait (Slow), 2012/10/24 17:31:20]

That is a possibility. The FaviconDownloadHelper only keeps a weak pointer to
its delegate, though. 

The other option would be to have a separate SetDelegate method, but seeing as
the FaviconDownloadHelper's  main purpose is to relay data back to the delegate,
there is not much point in creating an instance of it without a delegate...

   FindTabHelper::CreateForWebContents(contents);
   HistoryTabHelper::CreateForWebContents(contents);
   HungPluginTabHelper::CreateForWebContents(contents);