Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: chrome/browser/favicon/DEPS

Issue 11195010: Extract Favicon Download logic from FaviconTabHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Extract OnUpdateFaviconURL code Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/DEPS
diff --git a/chrome/browser/favicon/DEPS b/chrome/browser/favicon/DEPS
index 0b044f2ca6d9f4029efd73b0e5ef14ddc846dd42..3460227584801b1e6d340540649eae211fe10c8e 100644
--- a/chrome/browser/favicon/DEPS
+++ b/chrome/browser/favicon/DEPS
@@ -31,3 +31,25 @@
# Do not add to the list of temporarily-allowed dependencies above,
# and please do not introduce more #includes of these files.
]
+
+specific_include_rules = {
+ # TODO(caitkp): Look into removing history/ dependencies.
+ 'favicon_download_helper(_delegate)*\.(h|cc)': [
+ "-chrome",
+ "-chrome/browser",
+ "+chrome/browser/favicon/favicon_download_helper.h",
+ "+chrome/browser/favicon/favicon_download_helper_delegate.h",
+ "+chrome/browser/favicon/favicon_util.h",
+ "+chrome/common/icon_messages.h",
+ "+chrome/common/favicon_url.h",
+ ],
+
+ 'favicon_util\.(h|cc)': [
+ "-chrome",
+ "-chrome/browser",
+ "+chrome/browser/favicon/favicon_util.h",
+ "+chrome/common/icon_messages.h",
+ "!chrome/browser/history/history_types.h",
+ "!chrome/browser/history/select_favicon_frames.h",
+ ]
+}
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_download_helper.h » ('j') | chrome/browser/favicon/favicon_download_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698