Extract Favicon Download logic from FaviconTabHelper

chrome/browser/favicon/favicon_download_delegate.h

Index: chrome/browser/favicon/favicon_download_delegate.h
diff --git a/chrome/browser/favicon/favicon_download_delegate.h b/chrome/browser/favicon/favicon_download_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..0ec03f59f5e6a5f87e0115105446897a73858947
--- /dev/null
+++ b/chrome/browser/favicon/favicon_download_delegate.h
@@ -0,0 +1,25 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_FAVICON_FAVICON_DOWNLOAD_DELEGATE_H_
+#define CHROME_BROWSER_FAVICON_FAVICON_DOWNLOAD_DELEGATE_H_
+
+#include <vector>
+
+class GURL;
+class SkBitmap;
+
+// This class provides a delegate interface for a FaviconDownloadHelper.  It
+// allows the FaviconDownloadHelper to pass favicon data back to its caller.
+class FaviconDownloadDelegate {

[Jói, 2012/10/16 21:56:52]

Seems like this should be named FaviconDownloadHelperDelegate.

[Cait (Slow), 2012/10/17 16:00:42]

Done.

+ public:
+  virtual void OnDidDownloadFavicon(

[Jói, 2012/10/16 21:56:52]

Needs documentation.

[Cait (Slow), 2012/10/17 16:00:42]

Done.

+      int id,
+      const GURL& image_url,
+      bool errored,
+      int requested_size,
+      const std::vector<SkBitmap>& bitmaps) = 0;
+};
+
+#endif  // CHROME_BROWSER_FAVICON_FAVICON_DOWNLOAD_DELEGATE_H_