Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/favicon/DEPS

Issue 11195010: Extract Favicon Download logic from FaviconTabHelper (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # Favicon is being made into a Browser Component, so we have these 2 # Favicon is being made into a Browser Component, so we have these
3 # three basic rules followed by temporary exceptions. Please don't 3 # three basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/api", 6 "+chrome/browser/api",
7 "+chrome/browser/common", 7 "+chrome/browser/common",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 9
10 # Permanently-allowed DEPS beyond the standard Browser 10 # Permanently-allowed DEPS beyond the standard Browser
(...skipping 13 matching lines...) Expand all
24 "!chrome/browser/history/select_favicon_frames.h", 24 "!chrome/browser/history/select_favicon_frames.h",
25 "!chrome/browser/prefs/pref_service.h", 25 "!chrome/browser/prefs/pref_service.h",
26 "!chrome/browser/profiles/profile.h", 26 "!chrome/browser/profiles/profile.h",
27 "!chrome/browser/profiles/profile_dependency_manager.h", 27 "!chrome/browser/profiles/profile_dependency_manager.h",
28 "!chrome/browser/profiles/profile_keyed_service.h", 28 "!chrome/browser/profiles/profile_keyed_service.h",
29 "!chrome/browser/profiles/profile_keyed_service_factory.h", 29 "!chrome/browser/profiles/profile_keyed_service_factory.h",
30 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h", 30 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h",
31 # Do not add to the list of temporarily-allowed dependencies above, 31 # Do not add to the list of temporarily-allowed dependencies above,
32 # and please do not introduce more #includes of these files. 32 # and please do not introduce more #includes of these files.
33 ] 33 ]
34
35 specific_include_rules = {
36 # TODO(caitkp): Look into removing history/ dependencies.
37 'favicon_download_helper(_delegate)*\.(h|cc)': [
38 "-chrome",
39 "-chrome/browser",
40 "+chrome/browser/favicon/favicon_download_helper.h",
41 "+chrome/browser/favicon/favicon_download_helper_delegate.h",
42 "+chrome/browser/favicon/favicon_util.h",
43 "+chrome/common/icon_messages.h",
44 "+chrome/common/favicon_url.h",
45 ],
46
47 'favicon_util\.(h|cc)': [
48 "-chrome",
49 "-chrome/browser",
50 "+chrome/browser/favicon/favicon_util.h",
51 "+chrome/common/icon_messages.h",
52 "!chrome/browser/history/history_types.h",
53 "!chrome/browser/history/select_favicon_frames.h",
54 ]
55 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_download_helper.h » ('j') | chrome/browser/favicon/favicon_download_helper.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698