Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 include_rules = [ | 1 include_rules = [ |
| 2 # Favicon is being made into a Browser Component, so we have these | 2 # Favicon is being made into a Browser Component, so we have these |
| 3 # three basic rules followed by temporary exceptions. Please don't | 3 # three basic rules followed by temporary exceptions. Please don't |
| 4 # add to the list of exceptions! | 4 # add to the list of exceptions! |
| 5 "-chrome/browser", | 5 "-chrome/browser", |
| 6 "+chrome/browser/api", | 6 "+chrome/browser/api", |
| 7 "+chrome/browser/common", | 7 "+chrome/browser/common", |
| 8 "+chrome/browser/favicon", | 8 "+chrome/browser/favicon", |
| 9 | 9 |
| 10 # Permanently-allowed DEPS beyond the standard Browser | 10 # Permanently-allowed DEPS beyond the standard Browser |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 24 "!chrome/browser/history/select_favicon_frames.h", | 24 "!chrome/browser/history/select_favicon_frames.h", |
| 25 "!chrome/browser/prefs/pref_service.h", | 25 "!chrome/browser/prefs/pref_service.h", |
| 26 "!chrome/browser/profiles/profile.h", | 26 "!chrome/browser/profiles/profile.h", |
| 27 "!chrome/browser/profiles/profile_dependency_manager.h", | 27 "!chrome/browser/profiles/profile_dependency_manager.h", |
| 28 "!chrome/browser/profiles/profile_keyed_service.h", | 28 "!chrome/browser/profiles/profile_keyed_service.h", |
| 29 "!chrome/browser/profiles/profile_keyed_service_factory.h", | 29 "!chrome/browser/profiles/profile_keyed_service_factory.h", |
| 30 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h", | 30 "!chrome/browser/ui/webui/chrome_web_ui_controller_factory.h", |
| 31 # Do not add to the list of temporarily-allowed dependencies above, | 31 # Do not add to the list of temporarily-allowed dependencies above, |
| 32 # and please do not introduce more #includes of these files. | 32 # and please do not introduce more #includes of these files. |
| 33 ] | 33 ] |
| 34 | |
| 35 specific_include_rules = { | |
| 36 # TODO(caitkp): Look into removing history/ dependencies. | |
| 37 'favicon_download_helper(_delegate)*\.(h|cc)': [ | |
| 38 "-chrome", | |
| 39 "-chrome/browser", | |
| 40 "+chrome/browser/favicon", | |
|
Jói
2012/10/18 15:04:46
You probably don't want to allow all of chrome/bro
| |
| 41 "+chrome/common/icon_messages.h", | |
| 42 ], | |
| 43 | |
| 44 'favicon_util\.(h|cc)': [ | |
| 45 "-chrome", | |
| 46 "-chrome/browser", | |
| 47 "+chrome/browser/favicon", | |
| 48 "+chrome/common/icon_messages.h", | |
| 49 "!chrome/browser/history/history_types.h", | |
| 50 "!chrome/browser/history/select_favicon_frames.h", | |
| 51 ] | |
| 52 } | |
| OLD | NEW |