Simplify onclick action code.

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 623 matching lines @@
       // TODO(estade): can this just be textContent?
       $('sync-status-text').innerHTML = syncData.statusText;
       var statusSet = syncData.statusText.length != 0;
       $('sync-overview').hidden = statusSet;
       $('sync-status').hidden = !statusSet;
 
       $('sync-action-link').textContent = syncData.actionLinkText;
       $('sync-action-link').hidden = syncData.actionLinkText.length == 0;
       $('sync-action-link').disabled = syncData.managed;
 
-      if (cr.isChromeOS && syncData.hasError) {
-        // On Chrome OS, sign out the user and sign in again to get fresh
-        // credentials on auth errors.
-        $('sync-action-link').onclick = function(event) {
+      // On Chrome OS, sign out the user and sign in again to get fresh
+      // credentials on auth errors.
+      $('sync-action-link').onclick = function(event) {
+        if (cr.isChromeOS && syncData.hasError) {
           SyncSetupOverlay.doSignOutOnAuthError();
-        };
-      } else {
-        $('sync-action-link').onclick = function(event) {
+        } else {

[Evan Stade, 2012/10/18 23:35:41]

no curlies

[kochi, 2012/10/19 01:10:27]

Done.

           SyncSetupOverlay.showErrorUI();
-        };
-      }
+        }
+      };
 
       if (syncData.hasError)
         $('sync-status').classList.add('sync-error');
       else
         $('sync-status').classList.remove('sync-error');
 
       $('customize-sync').disabled = syncData.hasUnrecoverableError;
       // Move #enable-auto-login-checkbox to a different location on CrOS.
       if (cr.isChromeOs) {
         $('sync-general').insertBefore($('sync-status').nextSibling,
@@ skipping 674 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });