src/include/arm_sandbox.h - Issue 11194045: Change BKPT and UDF encodings on ARM.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/include/arm_sandbox.h

Issue 11194045: Change BKPT and UDF encodings on ARM. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Fix one test that was using bkpt #0x6666. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 /*

	2 * Copyright (c) 2012 The Native Client Authors. All rights reserved.

	3 * Use of this source code is governed by a BSD-style license that can be

	4 * found in the LICENSE file.

	5 */

	6

	7 /* Minimal ARM sandbox constants.
	Mark Seaborn 2012/10/19 18:08:43 Nit: NaCl comment style is /* * blah... / i.e. Nit: NaCl comment style is / * blah... / i.e. First line is '/' on its own.
	8 *

	9 * These constants are used in C code as well as assembly, hence the use of

	10 * the preprocessor.

	11 */

	12

	13 #ifndef NATIVE_CLIENT_SRC_INCLUDE_ARM_SANDBOX_H_

	14 #define NATIVE_CLIENT_SRC_INCLUDE_ARM_SANDBOX_H_ 1

	15

	16 /*

	17 * Specially chosen BKPT and UDF instructions that also correspond to

	18 * BKPT and UDF when decoded as Thumb instructions.

	19 * - BKPT #0x5BE0 is used as literal pool head.

	20 * - BKPT #0x5BEF is used as generic breakpoint.

	21 * - UDF #0xEDEF is used as halt-fill.

	22 * - UDF #0xEDE0 is used as abort-now (such as __builtin_trap).
	Mark Seaborn 2012/10/19 18:08:43 Why do you want to distinguish between abort-now a Why do you want to distinguish between abort-now and halt-fill? Can you add comments to explain when the differences are for debugging purposes, and when they affect safety?
	23 * - UDF #0xEDE1 is used to always fail validation.
	Mark Seaborn 2012/10/19 18:08:43 Please comment that this is one of many, but it's Please comment that this is one of many, but it's the one we are guaranteeing.
	24 * All other BKPT/UDF values are disallowed by the validator out of paranoia.

	25 */

	26 #define NACL_INSTR_LITERAL_POOL_HEAD 0xE125BE70

	27 #define NACL_INSTR_BREAKPOINT 0xE125BE7F

	28 #define NACL_INSTR_HALT_FILL 0xE7FEDEFF

	29 #define NACL_INSTR_ABORT_NOW 0xE7FEDEF0

	30 #define NACL_INSTR_FAIL_VALIDATION 0xE7FEDEF1

	31

	32 #endif /* NATIVE_CLIENT_SRC_INCLUDE_ARM_SANDBOX_H_ */

OLD	NEW

« no previous file with comments | « no previous file | src/include/nacl_macros.h » ('j') | tests/dynamic_code_loading/dyncode_demand_alloc_test.c » ('J')