Add keyboard events to metro aura

Add keyboard events to metro aura

This is the first part since there IME are issues
that need to be sorted out before this can fully
work. In particular, InputMethodEventFilter::PreHandleKeyEvent
needs changes not to assume native events.

BUG=151718
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162781

[cpu_(ooo_6.6-7.5), 2012-10-18 00:47:03]

also note I've broaden the #if defined(USE_AURA) blocks in metro_driver so we
have less code running that assumes non aura things.

[scottmg, 2012-10-18 00:53:18]

http://codereview.chromium.org/11194044/diff/1/chrome/browser/metro_viewer/me...
File chrome/browser/metro_viewer/metro_viewer_process_host_win.h (right):

http://codereview.chromium.org/11194044/diff/1/chrome/browser/metro_viewer/me...
chrome/browser/metro_viewer/metro_viewer_process_host_win.h:35: void
OnMouseEvent(int32 msg, WPARAM w_param, LPARAM l_param);
is it normal to use explicit sizes for ints in messages?

http://codereview.chromium.org/11194044/diff/1/win8/metro_driver/chrome_app_v...
File win8/metro_driver/chrome_app_view.cc (right):

http://codereview.chromium.org/11194044/diff/1/win8/metro_driver/chrome_app_v...
win8/metro_driver/chrome_app_view.cc:744: this,
&ChromeAppView::OnSizeChanged).Get(),
don't we still need this if we get snapped, etc?

[cpu_(ooo_6.6-7.5), 2012-10-18 20:15:26]

http://codereview.chromium.org/11194044/diff/1/chrome/browser/metro_viewer/me...
File chrome/browser/metro_viewer/metro_viewer_process_host_win.h (right):

http://codereview.chromium.org/11194044/diff/1/chrome/browser/metro_viewer/me...
chrome/browser/metro_viewer/metro_viewer_process_host_win.h:35: void
OnMouseEvent(int32 msg, WPARAM w_param, LPARAM l_param);
On 2012/10/18 00:53:19, scottmg wrote:
> is it normal to use explicit sizes for ints in messages?

Any integer type is fair game. The key ones don't need casting this way so I
felt that they look more uniform this way.

http://codereview.chromium.org/11194044/diff/1/win8/metro_driver/chrome_app_v...
File win8/metro_driver/chrome_app_view.cc (right):

http://codereview.chromium.org/11194044/diff/1/win8/metro_driver/chrome_app_v...
win8/metro_driver/chrome_app_view.cc:744: this,
&ChromeAppView::OnSizeChanged).Get(),
On 2012/10/18 00:53:19, scottmg wrote:
> don't we still need this if we get snapped, etc?

Yes we will, but the current impl assumes we have chrome.dll loaded and we
don't, so its mostly luck that we snap without crashing today.

The next change from me is probably splitting ChromeAppView in two classes so we
can do metro-ash and and legacy-metro without ifdefs everywhere.

[scottmg, 2012-10-18 20:20:07]

ship it! lgtm

[Ben Goodger (Google), 2012-10-18 20:42:26]

lgtm