To fix the cross-site post submission bug.

content/common/view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "content/common/content_export.h"
@@ skipping 27 matching lines @@
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPopupType.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebScreenInfo.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebTextDirection.h"
 #include "ui/base/dialogs/selected_file_info.h"
 #include "ui/base/ime/text_input_type.h"
 #include "ui/base/range/range.h"
 #include "ui/gfx/point.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/rect_f.h"
 #include "ui/gfx/vector2d.h"
+#include "webkit/glue/resource_request_body.h"
 #include "webkit/glue/webcookie.h"
 #include "webkit/glue/webmenuitem.h"
 #include "webkit/glue/webpreferences.h"
 #include "webkit/plugins/npapi/webplugin.h"
 
 #if defined(OS_MACOSX)
 #include "content/common/mac/font_descriptor.h"
 #endif
 
 #undef IPC_MESSAGE_EXPORT
@@ skipping 603 matching lines @@
   // The identifier of the RenderProcessHost for the new view attempting to
   // replace the closing one above.
   IPC_STRUCT_MEMBER(int, new_render_process_host_id)
 
   // The identifier of the *request* the new view made that is causing the
   // cross-site transition. This is *not* a route_id, but the request that we
   // will resume once the ACK from the closing view has been received.
   IPC_STRUCT_MEMBER(int, new_request_id)
 IPC_STRUCT_END()
 
+// Parameters for a resource request.
+IPC_STRUCT_TRAITS_BEGIN(content::ViewMsg_Request)
+  // The request method: GET, POST, etc.
+  IPC_STRUCT_TRAITS_MEMBER(method)
+
+  // The requested URL.
+  IPC_STRUCT_TRAITS_MEMBER(url)
+
+  // Additional HTTP request headers.
+  IPC_STRUCT_TRAITS_MEMBER(headers)
+
+  // Optional resource request body (may be null).
+  IPC_STRUCT_TRAITS_MEMBER(request_body)
+IPC_STRUCT_TRAITS_END()
+
 IPC_STRUCT_BEGIN(ViewMsg_Navigate_Params)
   // The page_id for this navigation, or -1 if it is a new navigation.  Back,
   // Forward, and Reload navigations should have a valid page_id.  If the load
   // succeeds, then this page_id will be reflected in the resultant
   // ViewHostMsg_FrameNavigate message.
   IPC_STRUCT_MEMBER(int32, page_id)
 
   // If page_id is -1, then pending_history_list_offset will also be -1.
   // Otherwise, it contains the offset into the history list corresponding to
   // the current navigation.
@@ skipping 45 matching lines @@
   IPC_STRUCT_MEMBER(bool, allow_download)
 
   // Whether or not the user agent override string should be used.
   IPC_STRUCT_MEMBER(bool, is_overriding_user_agent)
 
   // True if this was a post request.
   IPC_STRUCT_MEMBER(bool, is_post)
 
   // If is_post is true, holds the post_data information from browser. Empty
   // otherwise.
   IPC_STRUCT_MEMBER(std::vector<unsigned char>, browser_initiated_post_data)

[michaeln, 2012/11/02 00:08:23]

I think you're adding a new more expressive way to navigate by way of POST. How
do we reconcile the new way with what looks like an existing less expressive
way?

 
   // Whether or not this url should be allowed to access local file://
   // resources.
   IPC_STRUCT_MEMBER(bool, can_load_local_resources)
+
+  IPC_STRUCT_MEMBER(content::ViewMsg_Request, request)
 IPC_STRUCT_END()
 
 IPC_STRUCT_BEGIN(ViewMsg_New_Params)
   // The parent window's id.
   IPC_STRUCT_MEMBER(gfx::NativeViewId, parent_window)
 
   // Renderer-wide preferences.
   IPC_STRUCT_MEMBER(content::RendererPreferences, renderer_preferences)
 
   // Preferences for this view.
@@ skipping 1134 matching lines @@
                            bool         /* out - success */,
                            string16     /* out - user_input field */)
 
 // Requests that the given URL be opened in the specified manner.
 IPC_MESSAGE_ROUTED4(ViewHostMsg_OpenURL,
                     GURL /* url */,
                     content::Referrer /* referrer */,
                     WindowOpenDisposition /* disposition */,
                     int64 /* frame id */)
 
+// Requests that the given URL be opened in the specified manner.
+IPC_MESSAGE_ROUTED5(ViewHostMsg_OpenPostURL,
+                    GURL /* url */,
+                    content::Referrer /* referrer */,
+                    WindowOpenDisposition /* disposition */,
+                    int64 /* frame id */,
+                    content::ViewMsg_Request /* Request */)

[michaeln, 2012/11/02 00:08:23]

the request param also contains a url data member, is either the param or the
data member in the request struct redundant?

[irobert, 2012/11/02 17:22:55]

Done.

+
 // Notifies that the preferred size of the content changed.
 IPC_MESSAGE_ROUTED1(ViewHostMsg_DidContentsPreferredSizeChange,
                     gfx::Size /* pref_size */)
 
 // Notifies that the scrollbars-visible state of the content changed.
 IPC_MESSAGE_ROUTED2(ViewHostMsg_DidChangeScrollOffsetPinningForMainFrame,
                     bool /* has_horizontal_scrollbar */,
                     bool /* has_vertical_scrollbar */)
 
 // Notifies that the pinned-to-side state of the content changed.
@@ skipping 489 matching lines @@
 IPC_MESSAGE_ROUTED1(ViewHostMsg_StartContentIntent,
                     GURL /* content_url */)
 #endif
 
 // Notifies that multiple touch targets may have been pressed, and to show
 // the disambiguation popup.
 IPC_MESSAGE_ROUTED3(ViewHostMsg_ShowDisambiguationPopup,
                     gfx::Rect, /* Border of touched targets */
                     gfx::Size, /* Size of zoomed image */
                     TransportDIB::Id /* DIB of zoomed image */)