To fix the cross-site post submission bug.

chrome/browser/ui/browser_navigator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_NAVIGATOR_H_
 #define CHROME_BROWSER_UI_BROWSER_NAVIGATOR_H_
 
 #include <string>
 
 #include "chrome/browser/ui/host_desktop.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/global_request_id.h"
+#include "content/public/common/frame_navigate_params.h"
 #include "content/public/common/page_transition_types.h"
 #include "content/public/common/referrer.h"
 #include "googleurl/src/gurl.h"
 #include "ui/gfx/rect.h"
 #include "webkit/glue/window_open_disposition.h"
 
 class Browser;
 class Profile;
 class TabContents;
+using content::ViewMsg_Request;

[michaeln, 2012/11/02 00:08:23]

please avoid the use of using declarations in .h files to avoid potential
namespace collisions

[irobert, 2012/11/02 17:22:55]

Done.

 
 namespace chrome {
 
 // Parameters that tell Navigate() what to do.
 //
 // Some basic examples:
 //
 // Simple Navigate to URL in current tab:
 // chrome::NavigateParams params(browser, GURL("http://www.google.com/"),
 //                               content::PAGE_TRANSITION_LINK);
@@ skipping 164 matching lines @@
 
   // Refers to a navigation that was parked in the browser in order to be
   // transferred to another RVH. Only used in case of a redirection of a request
   // to a different site that created a new RVH.
   content::GlobalRequestID transferred_global_request_id;
 
   // Refers to which desktop this navigation should occur on. May be passed
   // explicitly or inferred from an existing Browser instance.
   chrome::HostDesktopType host_desktop_type;
 
+  // request
+  ViewMsg_Request request;

[michaeln, 2012/11/02 00:08:23]

There's some overlap between member of tha NavigateParams struct and members of
the new 'request' struct, in particular the 'url' members. The new info that's
missing from this struct seems to be the post data and the content type. I
wonder if the content type can go in the extra_headers field? The new transition
type implies 'POST' so not really sure we need the method string?

[irobert, 2012/11/02 17:22:55]

Yes. You are right. Since all the param structs in this path contain 'url' and
'extra header' field. I believe we can reuse them.

On 2012/11/02 00:08:23, michaeln wrote:

+
  private:
   NavigateParams();
 };
 
 // Navigates according to the configuration specified in |params|.
 void Navigate(NavigateParams* params);
 
 // Returns true if the url is allowed to open in incognito window.
 bool IsURLAllowedInIncognito(const GURL& url,
                              content::BrowserContext* browser_context);
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_UI_BROWSER_NAVIGATOR_H_