To fix the cross-site post submission bug.

content/common/view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "content/common/content_export.h"
@@ skipping 27 matching lines @@
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPopupType.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebScreenInfo.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebTextDirection.h"
 #include "ui/base/dialogs/selected_file_info.h"
 #include "ui/base/ime/text_input_type.h"
 #include "ui/base/range/range.h"
 #include "ui/gfx/point.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/rect_f.h"
 #include "ui/gfx/vector2d.h"
+#include "webkit/glue/resource_request_body.h"
 #include "webkit/glue/webcookie.h"
 #include "webkit/glue/webmenuitem.h"
 #include "webkit/glue/webpreferences.h"
 #include "webkit/plugins/npapi/webplugin.h"
 
 #if defined(OS_MACOSX)
 #include "content/common/mac/font_descriptor.h"
 #endif
 
 #undef IPC_MESSAGE_EXPORT
@@ skipping 671 matching lines @@
   IPC_STRUCT_MEMBER(bool, allow_download)
 
   // Whether or not the user agent override string should be used.
   IPC_STRUCT_MEMBER(bool, is_overriding_user_agent)
 
   // True if this was a post request.
   IPC_STRUCT_MEMBER(bool, is_post)
 
   // If is_post is true, holds the post_data information from browser. Empty
   // otherwise.
-  IPC_STRUCT_MEMBER(std::vector<unsigned char>, browser_initiated_post_data)
+  IPC_STRUCT_MEMBER(scoped_refptr<webkit_glue::ResourceRequestBody>,
+                    browser_initiated_post_data)
 
   // Whether or not this url should be allowed to access local file://
   // resources.
   IPC_STRUCT_MEMBER(bool, can_load_local_resources)
 IPC_STRUCT_END()
 
+// Parameters for a resource request.
+IPC_STRUCT_BEGIN(ViewMsg_PostRequest_Params)
+  IPC_STRUCT_MEMBER(std::string, extra_header)
+  IPC_STRUCT_MEMBER(scoped_refptr<webkit_glue::ResourceRequestBody>,
+                    request_body)
+IPC_STRUCT_END()
+
 IPC_STRUCT_BEGIN(ViewMsg_New_Params)
   // The parent window's id.
   IPC_STRUCT_MEMBER(gfx::NativeViewId, parent_window)
 
   // Renderer-wide preferences.
   IPC_STRUCT_MEMBER(content::RendererPreferences, renderer_preferences)
 
   // Preferences for this view.
   IPC_STRUCT_MEMBER(webkit_glue::WebPreferences, web_preferences)
 
@@ skipping 1132 matching lines @@
                            bool         /* out - success */,
                            string16     /* out - user_input field */)
 
 // Requests that the given URL be opened in the specified manner.
 IPC_MESSAGE_ROUTED4(ViewHostMsg_OpenURL,
                     GURL /* url */,
                     content::Referrer /* referrer */,
                     WindowOpenDisposition /* disposition */,
                     int64 /* frame id */)
 
+// Requests that the given URL be opened in the specified manner.
+IPC_MESSAGE_ROUTED5(ViewHostMsg_OpenPostURL,

[michaeln, 2012/11/05 23:38:29]

Instead of defining a new message that lives in parallel with the OpenURL
message, i think we should consider consolidating the two. Our ipc macros only
support up to 5 params. When we hit that limit, what we generally do is define a
'struct' to contain all of the params to be sent, and then spec the ipc to take
the struct only, and name the struct as such...

 IPC_MESSAGE_ROUTED1(ViewHostMsg_OpenURL,
                     ViewHostMsg_OpenURL_Params)

I think we could do that here and add the additional params for POST case to
that struct...
  bool is_post;
  std::string post_content_type;
  scoped_refptr<ResourceRequestBody> post_body;
  std::string post_method; // maybe this one isn't needed?

The way you've named the inner struct in this CL makes my eyes burn because it
doesn't really follow that pattern despite being named in that <msg_name>_Params
fashion.

[irobert, 2012/11/06 05:39:20]

Done.

+                    GURL /* url */,
+                    content::Referrer /* referrer */,
+                    WindowOpenDisposition /* disposition */,
+                    int64 /* frame id */,
+                    ViewMsg_PostRequest_Params /* request */)
+
 // Notifies that the preferred size of the content changed.
 IPC_MESSAGE_ROUTED1(ViewHostMsg_DidContentsPreferredSizeChange,
                     gfx::Size /* pref_size */)
 
 // Notifies that the scrollbars-visible state of the content changed.
 IPC_MESSAGE_ROUTED2(ViewHostMsg_DidChangeScrollOffsetPinningForMainFrame,
                     bool /* has_horizontal_scrollbar */,
                     bool /* has_vertical_scrollbar */)
 
 // Notifies that the pinned-to-side state of the content changed.
@@ skipping 489 matching lines @@
 IPC_MESSAGE_ROUTED1(ViewHostMsg_StartContentIntent,
                     GURL /* content_url */)
 #endif
 
 // Notifies that multiple touch targets may have been pressed, and to show
 // the disambiguation popup.
 IPC_MESSAGE_ROUTED3(ViewHostMsg_ShowDisambiguationPopup,
                     gfx::Rect, /* Border of touched targets */
                     gfx::Size, /* Size of zoomed image */
                     TransportDIB::Id /* DIB of zoomed image */)