Add the app.windows.getBounds method

chrome/browser/ui/views/extensions/shell_window_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/shell_window_views.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/ui/views/extensions/extension_keybinding_registry_views.h"
@@ skipping 666 matching lines @@
     if (!app_icon.IsEmpty())
       return *app_icon.ToImageSkia();
   }
   return gfx::ImageSkia();
 }
 
 bool ShellWindowViews::ShouldShowWindowTitle() const {
   return false;
 }
 
+void  ShellWindowViews::OnWidgetMove() {

[Mihai Parparita -not on Chrome, 2012/11/02 20:05:14]

Nit: extra space after void.

[asargent_no_longer_on_chrome, 2012/11/02 20:55:50]

Done.

+  shell_window_->SendBoundsUpdate();

[Mihai Parparita -not on Chrome, 2012/11/02 20:05:14]

Shouldn't this call It SaveWindowPlacement too?

In general, it seems awkward to have two (public) position-related methods in
ShellWindow that subclasses need to invoke. Can we just have a generic
OnWindowBoundsChanged that subclasses call, and then ShellWindow decides what to
do (save the persisted bounds, send them to the renderer, etc.)

[asargent_no_longer_on_chrome, 2012/11/02 20:55:50]

I had it that way initially, but in patch 3 of this review Jeremy was concerned
about doing lots of writes to disk (link: http://goo.gl/ALg4t). The
ShellWindowGeometryCache does wait for 1sec of quiescence before doing any
writes. 
Yeah, that's sort of a consequence of the above. Maybe better the way I had it
in patch set 3?

[Mihai Parparita -not on Chrome, 2012/11/02 22:12:56]

Yeah, I like that better (since it doesn't actually lead to any disk writes). I
would just suggest renaming SaveWindowPlacement to something a bit more generic,
and maybe making it private, with NativeShellWindow as a friend.

[asargent_no_longer_on_chrome, 2012/11/05 23:37:29]

Ok, I went back to just having the 1 method, but left it called
"SaveWindowPosition" for now to avoid having to add more owners to this review,
and have filed crbug.com/159508 for renaming it to "OnNativeBoundsChanged" and
having it call SaveWindowPosition and SendBoundsUpdate. 

Also, while the geometry cache won't do writes more frequently than after 1 sec
of quiescence, I've also filed crbug.com/159509 to make sure it doesn't do any
redundant writes if it gets updates that already match what is cached.

+}
+
 void ShellWindowViews::Layout() {
   DCHECK(web_view_);
   web_view_->SetBounds(0, 0, width(), height());
   OnViewWasResized();
 }
 
 void ShellWindowViews::UpdateWindowIcon() {
   window_->UpdateWindowIcon();
 }
 
@@ skipping 25 matching lines @@
                                            ui::WindowShowState show_state) {
   views::WidgetDelegate::SaveWindowPlacement(bounds, show_state);
   shell_window_->SaveWindowPosition();
 }
 
 // static
 NativeShellWindow* NativeShellWindow::Create(
     ShellWindow* shell_window, const ShellWindow::CreateParams& params) {
   return new ShellWindowViews(shell_window, params);
 }