settings: fix search

chrome/browser/resources/options/options_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /////////////////////////////////////////////////////////////////////////////
   // OptionsPage class:
 
   /**
    * Base class for options page.
@@ skipping 482 matching lines @@
                                          parentPage,
                                          associatedControls) {
     this.registeredOverlayPages[overlay.name.toLowerCase()] = overlay;
     overlay.parentPage = parentPage;
     if (associatedControls) {
       overlay.associatedControls = associatedControls;
       if (associatedControls.length) {
         overlay.associatedSection =
             this.findSectionForNode_(associatedControls[0]);
       }
+
+      // Sanity check.

[Dan Beam, 2012/10/16 22:27:45]

it's possible that you'd wrap this in an <if expr="debug"> 
(or however you do that in .js), but it just depends on how much you expect
users to hit this / help you repro

[Evan Stade, 2012/10/16 22:57:39]

since registerOverlay is called at startup, this completely breaks the page on
load. Developers can't help but notice it before it gets to users.

+      for (var i = 0; i < associatedControls.length; ++i) {
+        assert(associatedControls[i], 'Invalid element passed.');
+      }
     }
 
     // Reverse the button strip for views. See the documentation of
     // reverseButtonStrip_() for an explanation of why this is necessary.
     if (cr.isViews)
       this.reverseButtonStrip_(overlay);
 
     overlay.tab = undefined;
     overlay.isOverlay = true;
     overlay.initializePage();
@@ skipping 426 matching lines @@
     canShowPage: function() {
       return true;
     },
   };
 
   // Export
   return {
     OptionsPage: OptionsPage
   };
 });