sync: Merge apply updates and resolve conflicts

sync/engine/update_applicator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/engine/update_applicator.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "sync/engine/syncer_util.h"
-#include "sync/sessions/session_state.h"
 #include "sync/syncable/entry.h"
 #include "sync/syncable/mutable_entry.h"
 #include "sync/syncable/syncable_id.h"
 #include "sync/syncable/write_transaction.h"
 
 using std::vector;
 
 namespace syncer {
 
 using syncable::ID;
 
 UpdateApplicator::UpdateApplicator(Cryptographer* cryptographer,
                                    const ModelSafeRoutingInfo& routes,
                                    ModelSafeGroup group_filter)
     : cryptographer_(cryptographer),
       group_filter_(group_filter),
-      routing_info_(routes) {
+      routing_info_(routes),
+      updates_applied_(0),
+      encryption_conflicts_(0),
+      hierarchy_conflicts_(0) {
 }
 
 UpdateApplicator::~UpdateApplicator() {
 }
 
 // Attempt to apply all updates, using multiple passes if necessary.
 //
 // Some updates must be applied in order.  For example, children must be created
 // after their parent folder is created.  This function runs an O(n^2) algorithm
 // that will keep trying until there is nothing left to apply, or it stops
 // making progress, which would indicate that the hierarchy is invalid.
 //
 // The update applicator also has to deal with simple conflicts, which occur
-// when an item is modified on both the server and the local model, and
-// encryption conflicts.  There's not much we can do about them here, so we
-// don't bother re-processing them on subsequent passes.
+// when an item is modified on both the server and the local model.  We remember
+// their IDs so they can be passed to the conflict resolver after all the other
+// applications are complete.
+//
+// Finally, there are encryption conflicts, which can occur when we don't have
+// access to all the Nigori keys.  There's nothing we can do about them here.
 void UpdateApplicator::AttemptApplications(
     syncable::WriteTransaction* trans,
-    const std::vector<int64>& handles,
-    sessions::StatusController* status) {
+    const std::vector<int64>& handles) {
   std::vector<int64> to_apply = handles;
-  std::set<syncable::Id>* simple_conflict_ids =
-      status->mutable_simple_conflict_ids();
 
   DVLOG(1) << "UpdateApplicator running over " << to_apply.size() << " items.";
   while (!to_apply.empty()) {
     std::vector<int64> to_reapply;
 
-    for (UpdateIterator i = to_apply.begin(); i != to_apply.end(); ++i) {
+    for (std::vector<int64>::iterator i = to_apply.begin();
+         i != to_apply.end(); ++i) {
       syncable::Entry read_entry(trans, syncable::GET_BY_HANDLE, *i);
       if (SkipUpdate(read_entry)) {
         continue;
       }
 
       syncable::MutableEntry entry(trans, syncable::GET_BY_HANDLE, *i);
       UpdateAttemptResponse result = AttemptToUpdateEntry(
           trans, &entry, cryptographer_);
 
       switch (result) {
         case SUCCESS:
-          status->increment_num_updates_applied();
+          updates_applied_++;
           break;
         case CONFLICT_SIMPLE:
-          simple_conflict_ids->insert(entry.Get(ID));
+          simple_conflict_ids_.insert(entry.Get(ID));
           break;
         case CONFLICT_ENCRYPTION:
-          status->increment_num_encryption_conflicts();
+          encryption_conflicts_++;
           break;
         case CONFLICT_HIERARCHY:
           // The decision to classify these as hierarchy conflcits is tentative.
           // If we make any progress this round, we'll clear the hierarchy
           // conflict count and attempt to reapply these updates.
           to_reapply.push_back(*i);
           break;
         default:
           NOTREACHED();
           break;
       }
     }
 
     if (to_reapply.size() == to_apply.size()) {
       // We made no progress.  Must be stubborn hierarchy conflicts.
-      status->set_num_hierarchy_conflicts(to_apply.size());
+      hierarchy_conflicts_ = to_apply.size();
       break;
     }
 
     // We made some progress, so prepare for what might be another iteration.
     // If everything went well, to_reapply will be empty and we'll break out on
     // the while condition.
     to_apply.swap(to_reapply);
     to_reapply.clear();
   }
 }
@@ skipping 11 matching lines @@
       !routing_info_.count(type) &&
       type != UNSPECIFIED &&
       type != TOP_LEVEL_FOLDER) {
     DVLOG(1) << "Skipping update application, type not permitted.";
     return true;
   }
   return false;
 }
 
 }  // namespace syncer