Add chromeos::NetworkStateManager

chromeos/network/shill_service_observer.h

Index: chromeos/network/shill_service_observer.h
diff --git a/chromeos/network/shill_service_observer.h b/chromeos/network/shill_service_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..cb512c7deea1ea797df310326ed49e4e6fa2e6f3
--- /dev/null
+++ b/chromeos/network/shill_service_observer.h
@@ -0,0 +1,42 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_NETWORK_SHILL_SERVICE_OBSERVER_H_
+#define CHROMEOS_NETWORK_SHILL_SERVICE_OBSERVER_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "chromeos/dbus/shill_property_changed_observer.h"
+
+namespace chromeos {
+
+// Class to manage Shill service property changed observers. Observers are
+// added on construction and removed on destruction. Runs the handler when
+// OnPropertyChanged is called.
+class ShillServiceObserver : public ShillPropertyChangedObserver {

[gauravsh, 2012/11/06 01:56:59]

Would it be make sense to call this ShillServicePropertyHandler to be analogous
to ShillPropertyHandler (which is what internally uses it)?

[stevenjb, 2012/11/06 03:17:03]

This is specifically just an Observer. Originally it was
ShillPropertyHandler::ServiceObserver, but the official preference is to avoid
embedded classes. ShillPropertyHandlerServiceObserver seemed pretty lengthy,
especially since it doesn't have any explicit ShillPropertyHandler dependencies.

I've moved it to the internal:: namespace to make it clear that it's not a
public interface. I could possibly see renaming it ShillServicePropertyObserver?
That just seems a little redundant since, what else would we observe?

+ public:
+  typedef base::Callback<void(const std::string& service,
+                              const std::string& name,
+                              const base::Value& value)> Handler;
+
+  ShillServiceObserver(const std::string& service_path,
+                       const Handler& handler);
+
+  virtual ~ShillServiceObserver();
+
+  // ShillPropertyChangedObserver overrides.
+  virtual void OnPropertyChanged(const std::string& key,
+                                 const base::Value& value) OVERRIDE;
+
+ private:
+  std::string service_path_;
+  Handler handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(ShillServiceObserver);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_NETWORK_SHILL_SERVICE_OBSERVER_H_