Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chromeos/network/network_state_handler_unittest.cc

Issue 11192024: Add chromeos::NetworkStateManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Separate out NetworkStateHandlerImpl, address feedback Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chromeos/network/network_state_handler.h"
6
7 #include <map>
8 #include <set>
9 #include <string>
10
11 #include "base/bind.h"
12 #include "base/memory/scoped_ptr.h"
13 #include "base/message_loop.h"
14 #include "base/values.h"
15 #include "chromeos/dbus/dbus_thread_manager.h"
16 #include "chromeos/dbus/shill_service_client.h"
17 #include "chromeos/network/network_state.h"
18 #include "chromeos/network/network_state_handler_observer.h"
19 #include "dbus/object_path.h"
20 #include "testing/gtest/include/gtest/gtest.h"
21 #include "third_party/cros_system_api/dbus/service_constants.h"
22
23 namespace chromeos {
24
25 namespace {
26
27 void ErrorCallbackFunction(const std::string& error_name,
28 const std::string& error_message) {
29 LOG(ERROR) << "Shill Error: " << error_name << " : " << error_message;
30 }
31
32 class TestObserver : public NetworkStateHandlerObserver {
33 public:
34 TestObserver()
35 : manager_changed_count_(0),
36 network_count_(0) {
37 }
38
39 virtual ~TestObserver() {
40 }
41
42 virtual void NetworkManagerChanged() {
43 ++manager_changed_count_;
44 }
45
46 virtual void NetworkListChanged(
47 const NetworkStateHandler::NetworkStateList& networks) {
48 network_count_ = networks.size();
49 }
50
51 virtual void ActiveNetworkChanged(const NetworkState* network) {
52 active_network_ = network ? network->path() : "";
53 active_network_state_ = network ? network->state() : "";
54 }
55
56 virtual void ActiveNetworkStateChanged(const NetworkState* network) {
57 active_network_state_ = network ? network->state() : "";
58 }
59
60 virtual void NetworkServiceChanged(const NetworkState* network) {
61 DCHECK(network);
62 std::map<std::string, int>::iterator iter =
63 property_changes_.find(network->path());
64 if (iter == property_changes_.end())
65 property_changes_[network->path()] = 1;
66 else
67 iter->second++;
68 }
69
70 size_t manager_changed_count() { return manager_changed_count_; }
71 size_t network_count() { return network_count_; }
72 std::string active_network() { return active_network_; }
73 std::string active_network_state() { return active_network_state_; }
74
75 int PropertyChangesForService(const std::string& service_path) {
76 std::map<std::string, int>::iterator iter =
77 property_changes_.find(service_path);
78 if (iter == property_changes_.end())
79 return 0;
80 return iter->second;
81 }
82
83 private:
84 size_t manager_changed_count_;
85 size_t network_count_;
86 std::string active_network_;
87 std::string active_network_state_;
88 std::map<std::string, int> property_changes_;
89
90 DISALLOW_COPY_AND_ASSIGN(TestObserver);
91 };
92
93 } // namespace
94
95 class NetworkStateHandlerTest : public testing::Test {
96 public:
97 NetworkStateHandlerTest() {}
98 virtual ~NetworkStateHandlerTest() {}
99
100 virtual void SetUp() OVERRIDE {
101 // Initialize DBusThreadManager with a stub implementation.
102 DBusThreadManager::InitializeWithStub();
103 }
104
105 virtual void TearDown() OVERRIDE {
106 DBusThreadManager::Shutdown();
107 }
108
109 protected:
110 MessageLoopForUI message_loop_;
111
112 private:
113 DISALLOW_COPY_AND_ASSIGN(NetworkStateHandlerTest);
114 };
115
116 TEST_F(NetworkStateHandlerTest, NetworkStateHandlerStub) {
117 // This relies on the stub dbus implementations for ShillManagerClient,
118 scoped_ptr<NetworkStateHandler> state_manager(new NetworkStateHandler());
119 scoped_ptr<TestObserver> test_observer(new TestObserver());
120 state_manager->AddObserver(test_observer.get());
121 state_manager->Init();
122 message_loop_.RunAllPending();
123 EXPECT_EQ(1u, test_observer->manager_changed_count());
124 // ShillManagerClient stub entries are in shill_manager_client.cc.
125 const size_t kNumShillManagerClientStubImplServices = 4;
126 EXPECT_EQ(kNumShillManagerClientStubImplServices,
127 test_observer->network_count());
128 EXPECT_EQ(kNumShillManagerClientStubImplServices,
129 state_manager->NumObservedNetworksForTest());
130 const std::string kShillManagerClientStubActiveService = "stub_ethernet";
131 EXPECT_EQ(kShillManagerClientStubActiveService,
132 test_observer->active_network());
133 EXPECT_EQ(kShillManagerClientStubActiveService,
134 state_manager->ActiveNetwork()->path());
135 EXPECT_EQ(kShillManagerClientStubActiveService,
136 state_manager->ConnectedNetworkByType(
137 flimflam::kTypeEthernet)->path());
138 // ShillServiceClient stub entries are in shill_service_client.cc.
139 const std::string kShillManagerClientStubActiveServiceState =
140 flimflam::kStateOnline;
141 EXPECT_EQ(kShillManagerClientStubActiveServiceState,
142 test_observer->active_network_state());
143 }
144
145 TEST_F(NetworkStateHandlerTest, NetworkStateHandlerTechnologyChanged) {
146 // This relies on the stub dbus implementations for ShillManagerClient,
147 scoped_ptr<NetworkStateHandler> state_manager(new NetworkStateHandler());
148 scoped_ptr<TestObserver> test_observer(new TestObserver());
149 state_manager->AddObserver(test_observer.get());
150 state_manager->Init();
151 message_loop_.RunAllPending();
152 EXPECT_EQ(1u, test_observer->manager_changed_count());
153 // Enable a technology.
154 EXPECT_FALSE(state_manager->TechnologyEnabled(flimflam::kTypeWimax));
155 state_manager->SetTechnologyEnabled(flimflam::kTypeWimax, true);
156 message_loop_.RunAllPending();
157 // Ensure we get a manager changed callback when we change a property.
158 EXPECT_EQ(2u, test_observer->manager_changed_count());
159 EXPECT_TRUE(state_manager->TechnologyEnabled(flimflam::kTypeWimax));
160 }
161
162 TEST_F(NetworkStateHandlerTest, NetworkStateHandlerServicePropertyChanged) {
163 // This relies on the stub dbus implementations for ShillManagerClient,
164 scoped_ptr<NetworkStateHandler> state_manager(new NetworkStateHandler());
165 scoped_ptr<TestObserver> test_observer(new TestObserver());
166 state_manager->AddObserver(test_observer.get());
167 state_manager->Init();
168 message_loop_.RunAllPending();
169 // Set a service property.
170 const std::string eth0 = "stub_ethernet";
171 EXPECT_EQ("none", state_manager->GetNetworkState(eth0)->security());
172 EXPECT_EQ(0, test_observer->PropertyChangesForService(eth0));
173 DBusThreadManager::Get()->GetShillServiceClient()->SetProperty(
174 dbus::ObjectPath(eth0),
175 flimflam::kSecurityProperty, base::StringValue("TestSecurity"),
176 base::Bind(&base::DoNothing), base::Bind(&ErrorCallbackFunction));
177 message_loop_.RunAllPending();
178 EXPECT_EQ("TestSecurity", state_manager->GetNetworkState(eth0)->security());
179 EXPECT_EQ(1, test_observer->PropertyChangesForService(eth0));
180 }
181
182 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698