Add chromeos::NetworkStateManager

chromeos/network/network_service_observer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_NETWORK_NETWORK_SERVICE_OBSERVER_H_
+#define CHROMEOS_NETWORK_NETWORK_SERVICE_OBSERVER_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "chromeos/dbus/shill_property_changed_observer.h"
+
+// Class to manage Shill service property changed observers. Observers are
+// added on construction and removed on destruction. Runs the handler when
+// OnPropertyChanged is called.

[Greg Spencer (Chromium), 2012/10/23 23:19:10]

Move this down to just before the class definition.

[pneubeck (no reviews), 2012/10/24 14:41:42]

But when is that called? Only if the network is connected/connecting or also if
it's unconnected?
If it's the latter, why does the NetworkStateHandler only register observers for
connected/-ing networks?

[stevenjb, 2012/10/25 00:41:58]

Done.

[stevenjb, 2012/10/25 00:41:58]

This should get called when any property for an observed service changes.
However, your comment made me realize that there is a flaw in how
NetworkStateManager determines which services to observe (see the email I just
sent).

+

[pneubeck (no reviews), 2012/10/24 14:41:42]

forward declare base::Value

[stevenjb, 2012/10/25 00:41:58]

In the ShillPropertyChangedObserver signature so unnecessary.

+namespace chromeos {
+
+class NetworkServiceObserver : public ShillPropertyChangedObserver {
+ public:
+  typedef base::Callback<void(const std::string& service,
+                              const std::string& name,
+                              const base::Value& value)> Handler;
+
+  NetworkServiceObserver(const std::string& service_path, Handler handler);

[pneubeck (no reviews), 2012/10/24 14:41:42]

according to comments in callback.h,
callbacks should be passed as const&

[stevenjb, 2012/10/25 00:41:58]

Done.

+
+  virtual ~NetworkServiceObserver();
+
+  // ShillPropertyChangedObserver overrides.
+  virtual void OnPropertyChanged(const std::string& key,
+                                 const base::Value& value);
+
+ private:
+  std::string service_path_;
+  Handler handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkServiceObserver);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_NETWORK_NETWORK_SERVICE_OBSERVER_H_