Add chromeos::NetworkStateManager

chromeos/network/shill_service_observer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_NETWORK_SHILL_SERVICE_OBSERVER_H_
+#define CHROMEOS_NETWORK_SHILL_SERVICE_OBSERVER_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "chromeos/dbus/shill_property_changed_observer.h"
+
+namespace chromeos {
+
+// Class to manage Shill service property changed observers. Observers are
+// added on construction and removed on destruction. Runs the handler when

[gauravsh, 2012/10/25 23:41:05]

I'd move the 2nd sentence as a comment into the class (OnPropertyChanged or
where handler_ is defined.)

[stevenjb, 2012/10/26 21:36:39]

Since this has no public facing API, it seemed better to put all the comments at
top.

+// OnPropertyChanged is called.
+class ShillServiceObserver : public ShillPropertyChangedObserver {
+ public:
+  typedef base::Callback<void(const std::string& service,
+                              const std::string& name,
+                              const base::Value& value)> Handler;
+
+  ShillServiceObserver(const std::string& service_path,
+                       const Handler& handler);
+
+  virtual ~ShillServiceObserver();
+
+  // ShillPropertyChangedObserver overrides.
+  virtual void OnPropertyChanged(const std::string& key,
+                                 const base::Value& value);

[gauravsh, 2012/10/25 23:41:05]

OVERRIDE

[stevenjb, 2012/10/26 21:36:39]

Done.

+
+ private:
+  std::string service_path_;
+  Handler handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(ShillServiceObserver);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_NETWORK_SHILL_SERVICE_OBSERVER_H_