Add chromeos::NetworkStateManager

chromeos/network/device_state.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_NETWORK_DEVICE_STATE_H_
+#define CHROMEOS_NETWORK_DEVICE_STATE_H_
+
+#include "chromeos/network/managed_state.h"
+
+namespace chromeos {
+
+// Simple class to provide device state information. Similar to NetworkState;
+// see network_state.h for usage guidelines.
+class CHROMEOS_EXPORT DeviceState : public ManagedState {
+ public:
+  explicit DeviceState(const std::string& path);
+
+  // ManagedState overrides.
+  virtual bool PropertyChanged(const std::string& key,
+                               const base::Value& value) OVERRIDE;
+
+  // Accessors

[gauravsh, 2012/10/25 23:41:05]

NIT: . at the end

[stevenjb, 2012/10/26 21:36:39]

Actually, technically only sentences should have a '.'. Fixed 'ManagedState
overrides' above and did a consistency pass.

+  const std::string& name() const { return name_; }
+  const std::string& type() const { return type_; }
+  const std::string& mac_address() const { return mac_address_; }
+  bool always_in_roaming() const { return always_in_roaming_; }
+  bool support_network_scan() const { return support_network_scan_; }
+
+ private:
+  // Device Properties

[gauravsh, 2012/10/25 23:41:05]

NIT: . at the end.

[stevenjb, 2012/10/26 21:36:39]

ditto

+  std::string name_;
+  std::string type_;
+  std::string mac_address_;
+  std::string home_provider_id_;

[gauravsh, 2012/10/25 23:41:05]

Suggestion: separate out the properties that are used for WiFi vs. Cellular
devices.

+  bool always_in_roaming_;

[gauravsh, 2012/10/25 23:41:05]

Can you add a comment about what this tracks. Without knowing much about
cellular, I can't understand what this is useful for tracking.

[stevenjb, 2012/10/26 21:36:39]

Done.

+  bool support_network_scan_;
+
+  DISALLOW_COPY_AND_ASSIGN(DeviceState);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_NETWORK_DEVICE_STATE_H_