Add chromeos::NetworkStateManager

chromeos/network/network_service_observer.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_NETWORK_NETWORK_SERVICE_OBSERVER_H_
+#define CHROMEOS_NETWORK_NETWORK_SERVICE_OBSERVER_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "chromeos/dbus/shill_property_changed_observer.h"

[pneubeck (no reviews), 2012/10/25 14:42:17]

Btw. shill_property_changed_observer.h only forward declares base::Value.
Perhaps a point against your argument in the other file...

[stevenjb, 2012/10/25 22:05:22]

Forward declaration is sufficient here though, yes? Not sure I understand your
meaning.

+
+namespace chromeos {
+
+// Class to manage Shill service property changed observers. Observers are
+// added on construction and removed on destruction. Runs the handler when
+// OnPropertyChanged is called.
+class NetworkServiceObserver : public ShillPropertyChangedObserver {

[pneubeck (no reviews), 2012/10/25 14:42:17]

You could call this ShillServiceObserver to make the difference to NetworkState
and other Network* clearer.

[stevenjb, 2012/10/25 22:05:22]

Yeah, that's better, done.

+ public:
+  typedef base::Callback<void(const std::string& service,
+                              const std::string& name,
+                              const base::Value& value)> Handler;
+
+  NetworkServiceObserver(const std::string& service_path,
+                         const Handler& handler);
+
+  virtual ~NetworkServiceObserver();
+
+  // ShillPropertyChangedObserver overrides.
+  virtual void OnPropertyChanged(const std::string& key,
+                                 const base::Value& value);
+
+ private:
+  std::string service_path_;
+  Handler handler_;
+
+  DISALLOW_COPY_AND_ASSIGN(NetworkServiceObserver);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_NETWORK_NETWORK_SERVICE_OBSERVER_H_