Issue 1119003: Add new canned checks: CheckRietveldTryJobExecution and CheckBuildbotPendingBuilds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1119003: Add new canned checks: CheckRietveldTryJobExecution and CheckBuildbotPendingBuilds (Closed)

Created:
10 years, 9 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Description

Add new canned checks: CheckRietveldTryJobExecution and CheckBuildbotPendingBuilds These are the same that the one in chromium's src/PRESUBMIT.py but slightly more resilitent to exceptions. Empirical studies have shown that exceptions in presubmit checks result in disorientation and lack of willingness to commit. TEST=OMG new unit tests! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42102

Patch Set 1 #

Total comments: 3

Patch Set 2 : Standardize strings #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -33 lines)			Patch
	M	presubmit_canned_checks.py	View	1	22 chunks	+117 lines, -33 lines	0 comments	Download
	M	tests/presubmit_unittest.py	View		2 chunks	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 9 months ago (2010-03-18 21:27:55 UTC) #2

LGTM

http://codereview.chromium.org/1119003/diff/1/2
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/1119003/diff/1/2#newcode423
presubmit_canned_checks.py:423: url = "%s/%d/get_build_results/%d" % (
The quoting in this file is all over the map. Can you standardize it while
you're in there?

http://codereview.chromium.org/1119003/diff/1/2#newcode482
presubmit_canned_checks.py:482: "looking up buildbot status")]
-->

http://codereview.chromium.org/1119003/diff/1/3
File tests/presubmit_unittest.py (right):

http://codereview.chromium.org/1119003/diff/1/3#newcode1560
tests/presubmit_unittest.py:1560: connection.read().AndReturn("""amiga|Foo|blah
amiga :-)

Expand Messages | Collapse Messages