Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: webkit/plugins/npapi/plugin_instance.cc

Issue 11189146: Eliminate implicit conversion from scoped_refptr<T> to T* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_instance.h ('k') | webkit/plugins/npapi/plugin_stream_url.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_instance.cc
diff --git a/webkit/plugins/npapi/plugin_instance.cc b/webkit/plugins/npapi/plugin_instance.cc
index f26cbec67e55abfe8d767c60e63039af1b727a7c..3b367b24e40b37a6b20db7a19cad3ea10d07ba1e 100644
--- a/webkit/plugins/npapi/plugin_instance.cc
+++ b/webkit/plugins/npapi/plugin_instance.cc
@@ -97,7 +97,7 @@ void PluginInstance::AddStream(PluginStream* stream) {
open_streams_.push_back(make_scoped_refptr(stream));
}
-void PluginInstance::RemoveStream(PluginStream* stream) {
+void PluginInstance::RemoveStream(scoped_refptr<PluginStream> stream) {
if (in_close_streams_)
return;
@@ -547,7 +547,7 @@ void PluginInstance::RequestRead(NPStream* stream, NPByteRange* range_list) {
std::vector<scoped_refptr<PluginStream> >::iterator stream_index;
for (stream_index = open_streams_.begin();
stream_index != open_streams_.end(); ++stream_index) {
- PluginStream* plugin_stream = *stream_index;
+ scoped_refptr<PluginStream> plugin_stream = *stream_index;
if (plugin_stream->stream() == stream) {
// A stream becomes seekable the first time NPN_RequestRead
// is called on it.
@@ -668,7 +668,7 @@ void PluginInstance::URLRedirectResponse(bool allow, void* notify_data) {
std::vector<scoped_refptr<PluginStream> >::iterator stream_index;
for (stream_index = open_streams_.begin();
stream_index != open_streams_.end(); ++stream_index) {
- PluginStream* plugin_stream = *stream_index;
+ scoped_refptr<PluginStream> plugin_stream = *stream_index;
if (plugin_stream->notify_data() == notify_data) {
WebPluginResourceClient* resource_client =
plugin_stream->AsResourceClient();
« no previous file with comments | « webkit/plugins/npapi/plugin_instance.h ('k') | webkit/plugins/npapi/plugin_stream_url.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698