Issue 11189146: Eliminate implicit conversion from scoped_refptr<T> to T*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11189146: Eliminate implicit conversion from scoped_refptr<T> to T* (Closed)

Created:
8 years, 2 months ago by dmichael (off chromium)

Modified:
8 years ago

Reviewers:

CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, jam, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Eliminate implicit conversion from scoped_refptr<T> to T* BUG=110610 Closing uncommitted; willchan picked up the bug.

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -47 lines)			Patch
M	base/memory/ref_counted.h	View	1 chunk	+22 lines, -1 line	0 comments	Download
M	content/browser/device_orientation/message_filter.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	ipc/ipc_channel_proxy.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_sync_channel.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/plugin_globals.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/shared_impl/callback_tracker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/shared_impl/ppapi_globals.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/appcache/appcache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/appcache/appcache_storage_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/plugins/npapi/plugin_host.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_instance.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_instance.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/npapi/plugin_stream_url.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/npapi/webplugin_delegate_impl_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/host_globals.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/host_globals.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_graphics_2d_impl.cc	View	5 chunks	+11 lines, -10 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_image_data_impl.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_image_data_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download