chrome/browser/geolocation/geolocation_infobar_queue_controller.cc - Issue 11188020: Introduce Android variants of ChromeGeolocationPermissionContext, GeolocationConfirmInfoBarDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_infobar_queue_controller.cc

Issue 11188020: Introduce Android variants of ChromeGeolocationPermissionContext, GeolocationConfirmInfoBarDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing include Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/geolocation_confirm_infobar_delegate_factory.h ('K') | « chrome/browser/geolocation/geolocation_confirm_infobar_delegate_factory.cc ('k') | chrome/browser/geolocation/geolocation_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_infobar_queue_controller.cc

diff --git a/chrome/browser/geolocation/geolocation_infobar_queue_controller.cc b/chrome/browser/geolocation/geolocation_infobar_queue_controller.cc

index 9bbe26c0e85b56d8db490a92803254398258ca42..522f486a20da043815cfad54b7558ba2751e3a7f 100644

--- a/chrome/browser/geolocation/geolocation_infobar_queue_controller.cc

+++ b/chrome/browser/geolocation/geolocation_infobar_queue_controller.cc

@@ -5,7 +5,7 @@

#include "chrome/browser/geolocation/geolocation_infobar_queue_controller.h"

#include "chrome/browser/content_settings/host_content_settings_map.h"

-#include "chrome/browser/geolocation/geolocation_confirm_infobar_delegate.h"

+#include "chrome/browser/geolocation/geolocation_confirm_infobar_delegate_factory.h"

#include "chrome/browser/infobars/infobar.h"

#include "chrome/browser/infobars/infobar_tab_helper.h"

#include "chrome/browser/prefs/pref_service.h"

@@ -281,13 +281,13 @@ GeolocationInfoBarQueueController::CreateInfoBarDelegate(

int bridge_id,

const GURL& requesting_frame_url,

const std::string& display_languages) {

- return new GeolocationConfirmInfoBarDelegate(infobar_helper,

- controller,

- render_process_id,

- render_view_id,

- bridge_id,

- requesting_frame_url,

- display_languages);

+ return GeolocationConfirmInfoBarDelegateFactory::Create(infobar_helper,

bulach 2012/10/22 13:01:03 nit: calling code can be more compact, like: retur

Ramya 2012/10/22 20:58:04 Done.

+ controller,

+ render_process_id,

+ render_view_id,

+ bridge_id,

+ requesting_frame_url,

+ display_languages);

}

void GeolocationInfoBarQueueController::ShowQueuedInfoBar(