Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/chrome_remote_control/chrome_remote_control/adb_commands.py

Issue 11187036: Android: start upstreaming some of our perf tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tony's comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_remote_control/chrome_remote_control/adb_commands.py
diff --git a/tools/chrome_remote_control/chrome_remote_control/adb_commands.py b/tools/chrome_remote_control/chrome_remote_control/adb_commands.py
index d0a35286547725a0f01b0e436736ac2dccb2ed5f..41636f3aa2450fed0c0f0b33e0b675b686cf5aab 100644
--- a/tools/chrome_remote_control/chrome_remote_control/adb_commands.py
+++ b/tools/chrome_remote_control/chrome_remote_control/adb_commands.py
@@ -119,6 +119,7 @@ class AdbCommands(object):
def IsRootEnabled(self):
return self._adb.IsRootEnabled()
+
def HasForwarder(adb, buildtype=None):
if not buildtype:
return (HasForwarder(adb, buildtype='Release') or
@@ -126,11 +127,12 @@ def HasForwarder(adb, buildtype=None):
return (os.path.exists(os.path.join('out', buildtype, 'device_forwarder')) and
os.path.exists(os.path.join('out', buildtype, 'host_forwarder')))
+
class Forwarder(object):
def __init__(self, adb, host_port):
assert HasForwarder(adb)
- port_pairs = [(host_port, host_port), ]
+ port_pairs = [(0, host_port), ]
tonyg 2012/10/22 17:21:28 Are you sure this works? I wouldn't expect it to.
bulach 2012/10/22 17:29:02 that's a good point. it worked for me, but you con
tool = valgrind_tools.BaseTool()
self._host_port = host_port

Powered by Google App Engine
This is Rietveld 408576698