Use RejectAuthenticatingClient instead of DisconnectAllClients to reject incoming clients on curtai…

Use RejectAuthenticatingClient instead of DisconnectAllClients to reject incoming clients on curtain mode activation errors.

If we DisconnectAllClients from within the CurtainingHostObserver's OnClientAuthenticated callback, it will ultimately cause OnClientDisconnected callbacks for all HostStatusObservers to run *immediately*, before the OnClientAuthenticated for the next observer in the queue are called. This can cause the OnClientDisconnected callback for that observer to run *before* its OnClientAuthenticated callback.

For example, if HostUserInterface is enabled, a remote client tries to connect to the console, and curtaining fails, this will cause the local disconnect window to stay up after the client is rejected (before the Hide() call for the disconnection runs before Show()).

BUG=156254
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162376

[rmsousa, 2012-10-17 01:03:55]

It turned out that we need the different callbacks for the curtain mode after
all...

http://codereview.chromium.org/11187017/diff/1/remoting/host/remoting_me2me_h...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/11187017/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:607: DCHECK(host_);
Specifically, this must always be called from an OnClientAuthenticated callback
(this specific DCHECK is done inside host_->RejectAuthenticatingClient())

[Jamie, 2012-10-17 01:05:41]

Yikes! Thanks for spotting this one. LGTM.

[commit-bot: I haz the power, 2012-10-17 01:59:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/11187017/1

[commit-bot: I haz the power, 2012-10-17 11:18:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/11187017/1

[commit-bot: I haz the power, 2012-10-17 13:13:46]

Change committed as 162376