Use the NSS internal key slot for all temporary key operations

crypto/encryptor_nss.cc

Index: crypto/encryptor_nss.cc
diff --git a/crypto/encryptor_nss.cc b/crypto/encryptor_nss.cc
index cf4fa2a78d4ca04486940ca5d5ec8c27d85df9ef..d37c0669c6aad6d38812787266f711c0d79bfbd7 100644
--- a/crypto/encryptor_nss.cc
+++ b/crypto/encryptor_nss.cc
@@ -53,7 +53,7 @@ bool Encryptor::Init(SymmetricKey* key,
   if (mode == CBC && iv.size() != AES_BLOCK_SIZE)
     return false;
 
-  slot_.reset(PK11_GetBestSlot(GetMechanism(mode), NULL));
+  slot_.reset(PK11_GetInternalSlot());

[Ryan Sleevi, 2012/10/16 19:25:09]

wtc: It's not immediately clear to me why we even initialize slot_, since it
appears unused (PK11_CreateContextBySymKey will attempt to use the keys' slot).
Was this just meant to see if the mechanism was supported?

If so, should we be probing key's slot directly then?

[wtc, 2012/10/16 21:26:57]

We should remove the unused slot_ member. I guess this
was a code-copying mistake.

   if (!slot_.get())
     return false;