Added support for trace params to MakeURL. This fixes an issue where the trace= url parameter was s…

dashboard/ui/js/common.js

 /*
   Copyright (c) 2012 The Chromium Authors. All rights reserved.
   Use of this source code is governed by a BSD-style license that can be
   found in the LICENSE file.
 */
 
 /*
   Common methods for performance-plotting JS.
 */
 
@@ skipping 67 matching lines @@
   }
   if ('rev' in result) {
     result['rev'] = parseInt(result['rev']);
     result['rev'] = Math.max(result['rev'], -1);
   }
   return result;
 }
 
 // Creates the URL constructed from the current pathname and the given params.
 function MakeURL(params) {
-  var url = window.location.pathname;
-  var sep = '?';
-  for (p in params) {
-    if (!p)
-      continue;
-    url = url + sep + p + '=' + params[p];
-    sep = '&';
+  var arr = [];
+  for (var p in params) {
+    if (typeof params[p] == 'object') {
+      // Repeated params, stored as hash like {valueA: 1, valueB: 1}
+      for (var r in params[p]) {
+        arr.push(p + '=' + r);
+      }
+    } else {
+      arr.push(p + '=' + params[p]);
+    }
   }
-  return url;
+  return window.location.pathname + '?' + arr.join('&');
 }
 
 // Returns a string describing an object, recursively.  On the initial call,
 // |name| is optionally the name of the object and |indent| is not needed.
 function DebugDump(obj, opt_name, opt_indent) {
   var name = opt_name || '';
   var indent = opt_indent || '';
   if (typeof obj == "object") {
     var child = null;
     var output = indent + name + "\n";
@@ skipping 44 matching lines @@
     console.log(error)
     data = null;
   }
   this.fetchCount_--;
   this.data_[i] = data;
   if (this.fetchCount_ == 0) {
     this.callbackArgs_.unshift(this.data_);
     this.callback_.apply(this, this.callbackArgs_);
   }
 }