Added support for trace params to MakeURL. This fixes an issue where the trace= url parameter was s…

dashboard/ui/js/common.js

 /*
   Copyright (c) 2012 The Chromium Authors. All rights reserved.
   Use of this source code is governed by a BSD-style license that can be
   found in the LICENSE file.
 */
 
 /*
   Common methods for performance-plotting JS.
 */
 
@@ skipping 72 matching lines @@
   return result;
 }
 
 // Creates the URL constructed from the current pathname and the given params.
 function MakeURL(params) {
   var url = window.location.pathname;
   var sep = '?';
   for (p in params) {
     if (!p)
       continue;
-    url = url + sep + p + '=' + params[p];
+    var new_param = '';

[tonyg, 2012/10/16 18:28:29]

nit: newParam

+    if (typeof params[p] == "object") {
+      // Repeated param
+      var repeated = []

[tonyg, 2012/10/16 18:28:29]

nit: end with semicolon

+      for (r in params[p]) {
+        repeated.push(r + '=' + params[p][r]);
+      }
+      new_param = repeated.join("&");
+    }
+    else {

[tonyg, 2012/10/16 18:28:29]

Bring this up a line

+      new_param = p + '=' + params[p];
+    }
+    url = url + sep + new_param;
     sep = '&';
   }
   return url;
 }
 
 // Returns a string describing an object, recursively.  On the initial call,
 // |name| is optionally the name of the object and |indent| is not needed.
 function DebugDump(obj, opt_name, opt_indent) {
   var name = opt_name || '';
   var indent = opt_indent || '';
@@ skipping 47 matching lines @@
     console.log(error)
     data = null;
   }
   this.fetchCount_--;
   this.data_[i] = data;
   if (this.fetchCount_ == 0) {
     this.callbackArgs_.unshift(this.data_);
     this.callback_.apply(this, this.callbackArgs_);
   }
 }