Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: webkit/compositor_bindings/web_layer_impl.h

Issue 11175009: Implement SkImageFilter support in the compositor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODOs; comment out OVERRIDE. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/compositor_bindings/web_layer_impl.h
diff --git a/webkit/compositor_bindings/web_layer_impl.h b/webkit/compositor_bindings/web_layer_impl.h
index 88a433f597e3cc3ffa3b9c1f82fcf59901bb0f25..884fba249578438481575ee865257e90c8af472a 100644
--- a/webkit/compositor_bindings/web_layer_impl.h
+++ b/webkit/compositor_bindings/web_layer_impl.h
@@ -12,6 +12,9 @@ namespace cc {
class LayerChromium;
}
+// TODO(senorblanco): Remove this once WebKit changes have landed.
+class SkImageFilter;
+
namespace WebKit {
class WebLayerImpl : public WebLayer {
@@ -57,6 +60,8 @@ public:
virtual void setUseParentBackfaceVisibility(bool) OVERRIDE;
virtual void setBackgroundColor(WebColor) OVERRIDE;
virtual WebColor backgroundColor() const;
+ // TODO(senorblanco): uncomment OVERRIDE once WebKit changes have landed.
jamesr 2012/10/19 19:15:30 No, leave the OVERRIDE out. OVERRIDE's aren't wor
Stephen White 2012/10/19 21:34:50 Done.
+ virtual void setFilter(SkImageFilter*) /* OVERRIDE */;
virtual void setFilters(const WebFilterOperations&) OVERRIDE;
virtual void setBackgroundFilters(const WebFilterOperations&) OVERRIDE;
virtual void setDebugBorderColor(const WebColor&) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698