Implement SkImageFilter support in the compositor.

cc/layer.h

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef LayerChromium_h
 #define LayerChromium_h
 
 #include "CCLayerAnimationController.h"
 #include "CCOcclusionTracker.h"
 #include "FloatPoint.h"
 #include "Region.h"
 #include "base/memory/ref_counted.h"
 #include "cc/render_surface.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include <public/WebFilterOperations.h>
 #include <public/WebTransformationMatrix.h>
 #include <string>
 #include <vector>
 
 namespace WebKit {
 class WebAnimationDelegate;
 class WebLayerScrollClient;
 }
 
+class SkImageFilter;
+
 namespace cc {
 
 class CCActiveAnimation;
 struct CCAnimationEvent;
 class CCLayerAnimationDelegate;
 class CCLayerImpl;
 class CCLayerTreeHost;
 class CCPriorityCalculator;
 class CCTextureUpdateQueue;
 class ScrollbarLayerChromium;
@@ skipping 53 matching lines @@
     virtual void setNeedsDisplayRect(const FloatRect& dirtyRect);
     void setNeedsDisplay() { setNeedsDisplayRect(FloatRect(FloatPoint(), bounds())); }
     virtual bool needsDisplay() const;
 
     void setOpacity(float);
     bool opacityIsAnimating() const;
 
     void setFilters(const WebKit::WebFilterOperations&);
     const WebKit::WebFilterOperations& filters() const { return m_filters; }
 
+    void setFilter(SkImageFilter* filter);

[danakj, 2012/10/19 19:34:24]

same, setImageFilter?

[Stephen White, 2012/10/19 21:34:50]

Same as above.

+    SkImageFilter* filter() const { return m_filter; }
+
     // Background filters are filters applied to what is behind this layer, when they are viewed through non-opaque
     // regions in this layer. They are used through the WebLayer interface, and are not exposed to HTML.
     void setBackgroundFilters(const WebKit::WebFilterOperations&);
     const WebKit::WebFilterOperations& backgroundFilters() const { return m_backgroundFilters; }
 
     virtual void setContentsOpaque(bool);
     bool contentsOpaque() const { return m_contentsOpaque; }
 
     void setPosition(const FloatPoint&);
     FloatPoint position() const { return m_position; }
@@ skipping 220 matching lines @@
     bool m_haveWheelEventHandlers;
     Region m_nonFastScrollableRegion;
     bool m_nonFastScrollableRegionChanged;
     FloatPoint m_position;
     FloatPoint m_anchorPoint;
     SkColor m_backgroundColor;
     SkColor m_debugBorderColor;
     float m_debugBorderWidth;
     std::string m_debugName;
     float m_opacity;
+    SkImageFilter* m_filter;

[jamesr, 2012/10/19 19:15:30]

Should this be a SkTAutoUnref<> or something of that nature?  What should happen
if a filter is set on a Layer and then the layer is destroyed before we
pushPropertiesTo - we should drop a ref, right?

[Stephen White, 2012/10/19 21:34:50]

You're totally right.  Wow, what a doozy.

I've added explicit unrefs in the destructor so I can still do forward decl's,
and because Skia's smart pointers are so dumb.  :|

     WebKit::WebFilterOperations m_filters;
     WebKit::WebFilterOperations m_backgroundFilters;
     float m_anchorPointZ;
     bool m_isContainerForFixedPositionLayers;
     bool m_fixedToContainerLayer;
     bool m_isDrawable;
     bool m_masksToBounds;
     bool m_contentsOpaque;
     bool m_doubleSided;
     bool m_useLCDText;
@@ skipping 29 matching lines @@
 
     WebKit::WebAnimationDelegate* m_layerAnimationDelegate;
     WebKit::WebLayerScrollClient* m_layerScrollClient;
 };
 
 void sortLayers(std::vector<scoped_refptr<LayerChromium> >::iterator, std::vector<scoped_refptr<LayerChromium> >::iterator, void*);
 
 }  // namespace cc
 
 #endif