Change initialization interface of URLRequestJobFactory objects.

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 425 matching lines @@
 #if !defined(DISABLE_FTP_SUPPORT)
   ftp_factory_.reset(
       new net::FtpNetworkLayer(io_thread_globals->host_resolver.get()));
   main_context->set_ftp_transaction_factory(ftp_factory_.get());
   extensions_context->set_ftp_transaction_factory(ftp_factory_.get());
 #endif  // !defined(DISABLE_FTP_SUPPORT)
 
   main_context->set_chrome_url_data_manager_backend(
       chrome_url_data_manager_backend());
 
-  main_job_factory_.reset(new net::URLRequestJobFactoryImpl);
-  extensions_job_factory_.reset(new net::URLRequestJobFactoryImpl);
+  net::URLRequestJobFactoryImpl* main_job_factory =

[erikwright (departed), 2012/10/15 15:35:34]

same comments as previous file.

+      new net::URLRequestJobFactoryImpl();
+  main_job_factory_.reset(main_job_factory);
+  net::URLRequestJobFactoryImpl* extensions_job_factory =
+      new net::URLRequestJobFactoryImpl();
+  extensions_job_factory_.reset(extensions_job_factory);
 
-  SetUpJobFactory(main_job_factory_.get(),
+  SetUpJobFactory(main_job_factory,
                   profile_params->protocol_handler_interceptor.Pass(),
                   network_delegate(),
                   main_context->ftp_transaction_factory(),
                   main_context->ftp_auth_cache());
   // TODO(shalev): The extensions_job_factory has a NULL NetworkDelegate.
   // Without a network_delegate, this protocol handler will never
   // handle file: requests, but as a side effect it makes
   // job_factory::IsHandledProtocol return true, which prevents attempts to
   // handle the protocol externally. We pass NULL in to
   // SetUpJobFactory() to get this effect.
-  SetUpJobFactory(extensions_job_factory_.get(),
+  SetUpJobFactory(extensions_job_factory,
                   scoped_ptr<net::URLRequestJobFactoryImpl::Interceptor>(NULL),
                   NULL,
                   extensions_context->ftp_transaction_factory(),
                   extensions_context->ftp_auth_cache());
 
   main_context->set_job_factory(main_job_factory_.get());
   extensions_context->set_job_factory(extensions_job_factory_.get());
 
   // Create a media request context based on the main context, but using a
   // media cache.  It shares the same job factory as the main context.
@@ skipping 72 matching lines @@
     cookie_store = new net::CookieMonster(cookie_db.get(), NULL);
   }
 
   // Transfer ownership of the cookies and cache to AppRequestContext.
   context->SetCookieStore(cookie_store);
   context->SetHttpTransactionFactory(
       scoped_ptr<net::HttpTransactionFactory>(app_http_cache));
 
   // Overwrite the job factory that we inherit from the main context so
   // that we can later provide our own handles for storage related protocols.
-  scoped_ptr<net::URLRequestJobFactory> job_factory(
-      new net::URLRequestJobFactoryImpl());
-  SetUpJobFactory(job_factory.get(), protocol_handler_interceptor.Pass(),
+  net::URLRequestJobFactoryImpl* factory_impl =

[erikwright (departed), 2012/10/15 15:35:34]

same comments as previous file.

+      new net::URLRequestJobFactoryImpl();
+  scoped_ptr<net::URLRequestJobFactory> job_factory(factory_impl);
+  SetUpJobFactory(factory_impl, protocol_handler_interceptor.Pass(),
                   network_delegate(),
                   context->ftp_transaction_factory(),
                   context->ftp_auth_cache());
   context->SetJobFactory(job_factory.Pass());
 
   return context;
 }
 
 ChromeURLRequestContext*
 ProfileImplIOData::InitializeMediaRequestContext(
@@ skipping 75 matching lines @@
   DCHECK(media_request_context);
   return media_request_context;
 }
 
 chrome_browser_net::LoadTimeStats* ProfileImplIOData::GetLoadTimeStats(
     IOThread::Globals* io_thread_globals) const {
   return io_thread_globals->load_time_stats.get();
 }
 
 void ProfileImplIOData::SetUpJobFactory(
-    net::URLRequestJobFactory* job_factory,
+    net::URLRequestJobFactoryImpl* job_factory,
     scoped_ptr<net::URLRequestJobFactory::Interceptor>
         protocol_handler_interceptor,
     net::NetworkDelegate* network_delegate,
     net::FtpTransactionFactory* ftp_transaction_factory,
     net::FtpAuthCache* ftp_auth_cache) const {
   SetUpJobFactoryDefaults(job_factory, protocol_handler_interceptor.Pass(),
                           network_delegate, ftp_transaction_factory,
                           ftp_auth_cache);
 
   job_factory->AddInterceptor(
       new chrome_browser_net::ConnectInterceptor(predictor_.get()));
 }
 
 void ProfileImplIOData::ClearNetworkingHistorySinceOnIOThread(
     base::Time time) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   LazyInitialize();
 
   DCHECK(transport_security_state());
   transport_security_state()->DeleteSince(time);
   DCHECK(http_server_properties_manager());
   http_server_properties_manager()->Clear();
 }