Handle the case where IAttachmentExecute::Save() deletes a downloaded file.

content/browser/download/download_item_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 198 matching lines @@
  private:
   // Fine grained states of a download.
   enum DownloadInternalState {
     // Unless otherwise specified, state transitions are linear forward
     // in this list.
 
     // Includes both before and after file name determination.
     // TODO(rdsmith): Put in state variable for file name determination.
     IN_PROGRESS_INTERNAL,
 
     // Between commit point (dispatch of download file release) and

[Randy Smith (Not in Mondays), 2012/10/16 18:19:19]

Could you add a note here about how the Download is blocked from being cancelled
in this state, but may still be interrupted if the operations break?  (I'm
pretty sure this is a reasonable choice, but another choice to keep
cancelableness and interruptibleness in sync would be to separate out annotation
(with error return) from detach, and not transition to COMPLETING_INTERNAL until
detach.

[asanka, 2012/10/25 23:51:27]

Done.

     // completed.  Embedder may be opening the file in this state.
     // Note that the DownloadItem may be deleted (by shutdown) in this
     // state.
     COMPLETING_INTERNAL,
 
     // After embedder has had a chance to auto-open.  User may now open
     // or auto-open based on extension.
     COMPLETE_INTERNAL,
 
     // User has cancelled the download.
@@ skipping 23 matching lines @@
       content::DownloadInterruptReason reason, const FilePath& full_path);
 
   // If all pre-requisites have been met, complete download processing, i.e. do
   // internal cleanup, file rename, and potentially auto-open.  (Dangerous
   // downloads still may block on user acceptance after this point.)
   void MaybeCompleteDownload();
 
   void OnDownloadRenamedToFinalName(content::DownloadInterruptReason reason,
                                     const FilePath& full_path);
 
-  void OnDownloadFileReleased();
+  void OnDownloadFileReleased(content::DownloadInterruptReason reason);
 
   // Called when the entire download operation (including renaming etc)
   // is completed.
   void Completed();
 
   // Helper routines -----------------------------------------------------------
 
   // Returns true if the download still needs to be renamed to
   // GetTargetFilePath().
   bool NeedsRename() const;
@@ skipping 178 matching lines @@
 
   // Net log to use for this download.
   const net::BoundNetLog bound_net_log_;
 
   base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl);
 };
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_