Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: remoting/remoting.gyp

Issue 11150008: Move Chromoting strings to string_resources.grd. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/resources/string_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting.gyp
diff --git a/remoting/remoting.gyp b/remoting/remoting.gyp
index 5a606086e7aee40394bccb3365e97526c0ae1305..fc6dd9a774c890b44972f6268f0a12a432282fb6 100644
--- a/remoting/remoting.gyp
+++ b/remoting/remoting.gyp
@@ -34,6 +34,8 @@
'branding_path': '../remoting/branding_<(branding)',
'copyright_info': '<!(python <(version_py_path) -f <(branding_path) -t "@COPYRIGHT@")',
+ 'webapp_locale_dir': '<(SHARED_INTERMEDIATE_DIR)/remoting/webapp/_locales',
+
# Use consistent strings across all platforms.
# These values must match host/plugin/constants.h
'host_plugin_mime_type': 'application/vnd.chromium.remoting-host',
@@ -69,52 +71,52 @@
['branding=="Chrome"', {
'remoting_webapp_locale_files': [
- 'webapp/_locales.official/ar/messages.json',
- 'webapp/_locales.official/bg/messages.json',
- 'webapp/_locales.official/ca/messages.json',
- 'webapp/_locales.official/cs/messages.json',
- 'webapp/_locales.official/da/messages.json',
- 'webapp/_locales.official/de/messages.json',
- 'webapp/_locales.official/el/messages.json',
- 'webapp/_locales.official/en/messages.json',
- 'webapp/_locales.official/en_GB/messages.json',
- 'webapp/_locales.official/es/messages.json',
- 'webapp/_locales.official/es_419/messages.json',
- 'webapp/_locales.official/et/messages.json',
- 'webapp/_locales.official/fi/messages.json',
- 'webapp/_locales.official/fil/messages.json',
- 'webapp/_locales.official/fr/messages.json',
- 'webapp/_locales.official/he/messages.json',
- 'webapp/_locales.official/hi/messages.json',
- 'webapp/_locales.official/hr/messages.json',
- 'webapp/_locales.official/hu/messages.json',
- 'webapp/_locales.official/id/messages.json',
- 'webapp/_locales.official/it/messages.json',
- 'webapp/_locales.official/ja/messages.json',
- 'webapp/_locales.official/ko/messages.json',
- 'webapp/_locales.official/lt/messages.json',
- 'webapp/_locales.official/lv/messages.json',
- 'webapp/_locales.official/nb/messages.json',
- 'webapp/_locales.official/nl/messages.json',
- 'webapp/_locales.official/pl/messages.json',
- 'webapp/_locales.official/pt_BR/messages.json',
- 'webapp/_locales.official/pt_PT/messages.json',
- 'webapp/_locales.official/ro/messages.json',
- 'webapp/_locales.official/ru/messages.json',
- 'webapp/_locales.official/sk/messages.json',
- 'webapp/_locales.official/sl/messages.json',
- 'webapp/_locales.official/sr/messages.json',
- 'webapp/_locales.official/sv/messages.json',
- 'webapp/_locales.official/th/messages.json',
- 'webapp/_locales.official/tr/messages.json',
- 'webapp/_locales.official/uk/messages.json',
- 'webapp/_locales.official/vi/messages.json',
- 'webapp/_locales.official/zh_CN/messages.json',
- 'webapp/_locales.official/zh_TW/messages.json',
+ '<(webapp_locale_dir)/ar/messages.json',
Jamie 2012/10/15 04:06:38 This will fail for an official build because the "
Sergey Ulanov 2012/10/15 18:57:22 Now the messages.json files are generated from grd
+ '<(webapp_locale_dir)/bg/messages.json',
+ '<(webapp_locale_dir)/ca/messages.json',
+ '<(webapp_locale_dir)/cs/messages.json',
+ '<(webapp_locale_dir)/da/messages.json',
+ '<(webapp_locale_dir)/de/messages.json',
+ '<(webapp_locale_dir)/el/messages.json',
+ '<(webapp_locale_dir)/en/messages.json',
+ '<(webapp_locale_dir)/en_GB/messages.json',
+ '<(webapp_locale_dir)/es/messages.json',
+ '<(webapp_locale_dir)/es_419/messages.json',
+ '<(webapp_locale_dir)/et/messages.json',
+ '<(webapp_locale_dir)/fi/messages.json',
+ '<(webapp_locale_dir)/fil/messages.json',
+ '<(webapp_locale_dir)/fr/messages.json',
+ '<(webapp_locale_dir)/he/messages.json',
+ '<(webapp_locale_dir)/hi/messages.json',
+ '<(webapp_locale_dir)/hr/messages.json',
+ '<(webapp_locale_dir)/hu/messages.json',
+ '<(webapp_locale_dir)/id/messages.json',
+ '<(webapp_locale_dir)/it/messages.json',
+ '<(webapp_locale_dir)/ja/messages.json',
+ '<(webapp_locale_dir)/ko/messages.json',
+ '<(webapp_locale_dir)/lt/messages.json',
+ '<(webapp_locale_dir)/lv/messages.json',
+ '<(webapp_locale_dir)/nb/messages.json',
+ '<(webapp_locale_dir)/nl/messages.json',
+ '<(webapp_locale_dir)/pl/messages.json',
+ '<(webapp_locale_dir)/pt_BR/messages.json',
+ '<(webapp_locale_dir)/pt_PT/messages.json',
+ '<(webapp_locale_dir)/ro/messages.json',
+ '<(webapp_locale_dir)/ru/messages.json',
+ '<(webapp_locale_dir)/sk/messages.json',
+ '<(webapp_locale_dir)/sl/messages.json',
+ '<(webapp_locale_dir)/sr/messages.json',
+ '<(webapp_locale_dir)/sv/messages.json',
+ '<(webapp_locale_dir)/th/messages.json',
+ '<(webapp_locale_dir)/tr/messages.json',
+ '<(webapp_locale_dir)/uk/messages.json',
+ '<(webapp_locale_dir)/vi/messages.json',
+ '<(webapp_locale_dir)/zh_CN/messages.json',
+ '<(webapp_locale_dir)/zh_TW/messages.json',
],
}, { # else: branding!="Chrome"
'remoting_webapp_locale_files': [
- 'webapp/_locales/en/messages.json',
+ '<(webapp_locale_dir)/en/messages.json',
],
}],
['OS=="win"', {
@@ -1145,6 +1147,7 @@
'target_name': 'remoting_webapp',
'type': 'none',
'dependencies': [
+ 'remoting_resources',
Jamie 2012/10/15 04:06:38 This change seems unrelated to anything else in th
Sergey Ulanov 2012/10/15 18:57:22 It is related. remoting_resources target now gener
'remoting_host_plugin',
],
'sources': [
@@ -1166,7 +1169,7 @@
'action_name': 'Verify Remoting WebApp i18n',
'inputs': [
'host/plugin/host_script_object.cc',
- 'webapp/_locales/en/messages.json',
+ '<(webapp_locale_dir)/en/messages.json',
'webapp/client_screen.js',
'webapp/host_controller.js',
'webapp/host_table_entry.js',
@@ -1183,7 +1186,7 @@
'python',
'webapp/verify-webapp.py',
'<(PRODUCT_DIR)/remoting/webapp_verified.stamp',
- 'webapp/_locales/en/messages.json',
+ '<(webapp_locale_dir)/en/messages.json',
'webapp/client_screen.js',
'webapp/host_controller.js',
'webapp/host_table_entry.js',
« no previous file with comments | « no previous file | remoting/resources/string_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698