Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 11150008: Move Chromoting strings to string_resources.grd. (Closed)

Created:
8 years, 2 months ago by Sergey Ulanov
Modified:
8 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Move Chromoting strings to string_resources.grd. Previously all strings were in messages.json files. Moving them to GRD file will allow to share them with native components. Also added script that I used to convert translations - to make it easier to review this CL and just in case we need it again in the future.

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5554 lines, -16746 lines) Patch
M remoting/remoting.gyp View 1 2 3 6 chunks +100 lines, -48 lines 0 comments Download
M remoting/resources/string_resources.grd View 2 3 1 chunk +460 lines, -7 lines 0 comments Download
A remoting/resources/string_resources_ar.xtb View 1 2 3 1 chunk +115 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_bg.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_ca.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_cs.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_da.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_de.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_el.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_en-GB.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_en_US.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_es.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_es-419.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_et.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_fi.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_fil.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_fr.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_he.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_hi.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_hr.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_hu.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_id.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_it.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_ja.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_ko.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_lt.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_lv.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_nb.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_nl.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_pl.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_pt-BR.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_pt-PT.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_ro.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_ru.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_sk.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_sl.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_sr.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_sv.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_th.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_tr.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_uk.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_vi.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_zh-CN.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/resources/string_resources_zh-TW.xtb View 1 2 3 1 chunk +114 lines, -0 lines 0 comments Download
A remoting/tools/json_to_grd.py View 1 2 3 1 chunk +190 lines, -0 lines 0 comments Download
M remoting/tools/remove_official_branding.py View 2 3 1 chunk +10 lines, -4 lines 0 comments Download
D remoting/webapp/_locales.official/ar/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/bg/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/ca/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/cs/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/da/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/de/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/el/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/en/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/en_GB/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/es/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/es_419/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/et/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/fi/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/fil/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/fr/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/he/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/hi/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/hr/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/hu/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/id/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/it/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/ja/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/ko/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/lt/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/lv/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/nb/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/nl/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/pl/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/pt_BR/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/pt_PT/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/ro/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/ru/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/sk/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/sl/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/sr/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/sv/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/th/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/tr/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/uk/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/vi/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/zh_CN/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales.official/zh_TW/messages.json View 1 2 3 1 chunk +0 lines, -385 lines 0 comments Download
D remoting/webapp/_locales/en/messages.json View 1 2 3 1 chunk +0 lines, -507 lines 0 comments Download
M remoting/webapp/build-webapp.py View 2 3 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Sergey Ulanov
8 years, 2 months ago (2012-10-13 21:56:26 UTC) #1
Jamie
This CL seems to get rid of all the JSON files without adding a script ...
8 years, 2 months ago (2012-10-15 04:06:37 UTC) #2
Sergey Ulanov
> This CL seems to get rid of all the JSON files without adding a ...
8 years, 2 months ago (2012-10-15 18:57:21 UTC) #3
Jamie
Okay, that makes sense. So this CL is dependent on that one then? That being ...
8 years, 2 months ago (2012-10-15 20:13:23 UTC) #4
Sergey Ulanov
On 2012/10/15 20:13:23, Jamie wrote: > Okay, that makes sense. So this CL is dependent ...
8 years, 2 months ago (2012-10-16 20:19:41 UTC) #5
Sergey Ulanov
Jamie: ping
8 years, 2 months ago (2012-10-18 18:44:15 UTC) #6
Jamie
On 2012/10/18 18:44:15, sergeyu wrote: > Jamie: ping lgtm, although I haven't looked at json_to_grd ...
8 years, 2 months ago (2012-10-18 19:35:51 UTC) #7
Sergey Ulanov
On 2012/10/18 19:35:51, Jamie wrote: > On 2012/10/18 18:44:15, sergeyu wrote: > > Jamie: ping ...
8 years, 2 months ago (2012-10-18 20:12:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11150008/35001
8 years, 1 month ago (2012-10-30 20:49:02 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-10-30 22:34:55 UTC) #10
Change committed as 165041

Powered by Google App Engine
This is Rietveld 408576698