Initial refactor to get profiles to propagate storage partition details.

chrome/browser/ui/webui/options/cookies_view_handler.cc

Index: chrome/browser/ui/webui/options/cookies_view_handler.cc
diff --git a/chrome/browser/ui/webui/options/cookies_view_handler.cc b/chrome/browser/ui/webui/options/cookies_view_handler.cc
index 065c3dc51829c12fd65897090aaeb2c235a88b74..a622a17712c71d80370cc95672a2a3fd7aceef4a 100644
--- a/chrome/browser/ui/webui/options/cookies_view_handler.cc
+++ b/chrome/browser/ui/webui/options/cookies_view_handler.cc
@@ -25,6 +25,8 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/cookies_tree_model_util.h"
 #include "content/public/browser/browser_context.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/site_instance.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/generated_resources.h"
@@ -223,13 +225,18 @@ void CookiesViewHandler::EnsureCookiesTreeModelCreated() {
     Profile* profile = Profile::FromWebUI(web_ui());
     ContainerMap apps_map;
     const ExtensionService* service = profile->GetExtensionService();
-    if (service) {
+    ExtensionProcessManager* process_manager =
+      profile->GetExtensionProcessManager();

[awong, 2012/10/29 23:37:40]

2 more spaces

[nasko, 2012/10/30 00:32:59]

Done.

+    if (service && process_manager) {
       const ExtensionSet* extensions = service->extensions();
       for (ExtensionSet::const_iterator it = extensions->begin();
            it != extensions->end(); ++it) {
         if ((*it)->is_storage_isolated()) {
+          content::StoragePartition* storage_partition =
+            content::BrowserContext::GetStoragePartitionForSite(profile,
+                                                                (*it)->url());
           net::URLRequestContextGetter* context_getter =
-              profile->GetRequestContextForStoragePartition((*it)->id());
+            storage_partition->GetURLRequestContext();

[awong, 2012/10/29 23:37:40]

Why is this changing? Is it just cleanup, or is there some subtle bug I'm
missing?

[nasko, 2012/10/30 00:32:59]

Because GetRequestContextForStoragePartition is changing from taking a
partition_id string to taking FilePath and bool. We don't have those here, so it
needs to go through the BrowserContext to get the partition.

That said, I think we need to remove his code based on our discussion of
isolated sites today. This code was added for supporting the "Apps cookies"
dialog, which will not be shipping if we don't do isolated sites.

           // TODO(nasko): When new types of storage are isolated, add the
           // appropriate browsing data helper objects to the constructor.
           // For now, just cookies are isolated, so other parameters are NULL.