Initial refactor to get profiles to propagate storage partition details.

content/browser/storage_partition_impl_map.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/storage_partition_impl_map.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/stl_util.h"
@@ skipping 193 matching lines @@
   // There was no previous partition, so let's make a new one.
   StoragePartitionImpl* partition =
       StoragePartitionImpl::Create(browser_context_, partition_id,
                                    browser_context_->GetPath());
   partitions_[partition_id] = partition;
 
   // These calls must happen after StoragePartitionImpl::Create().
   partition->SetURLRequestContext(
       partition_id.empty() ?
       browser_context_->GetRequestContext() :
-      browser_context_->GetRequestContextForStoragePartition(partition_id));
+      browser_context_->GetRequestContextForStoragePartition(
+          partition->GetPath(), partition->InMemory()));

[awong, 2012/10/19 21:20:24]

This is the only usage of InMemory() I think.  Can't we discern the "in memory"
in this function?

Then I don't think StoragePartition needs to keep this information and we don't
need to add it to the public API.

[nasko, 2012/10/19 22:09:00]

Done.

   partition->SetMediaURLRequestContext(
       partition_id.empty() ?
       browser_context_->GetMediaRequestContext() :
       browser_context_->GetMediaRequestContextForStoragePartition(
-          partition_id));
+          partition->GetPath(), partition->InMemory()));
 
   PostCreateInitialization(partition);
 
   // TODO(ajwong): ResourceContexts no longer have any storage related state.
   // We should move this into a place where it is called once per
   // BrowserContext creation rather than piggybacking off the default context
   // creation.
   if (partition_id.empty()) {
     InitializeResourceContext(browser_context_);
   }
@@ skipping 39 matching lines @@
 
     // We do not call InitializeURLRequestContext() for media contexts because,
     // other than the HTTP cache, the media contexts share the same backing
     // objects as their associated "normal" request context.  Thus, the previous
     // call serves to initialize the media request context for this storage
     // partition as well.
   }
 }
 
 }  // namespace content