Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11146023: Work on separate browser contexts (Closed)

Created:
8 years, 2 months ago by scottmg
Modified:
8 years, 2 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, Ian Vollick, tfarina, jonathan.backer, mazda+watch_chromium.org, piman+watch_chromium.org
Visibility:
Public.

Description

Always start up in --desktop-aura mode now, and open ash from tools menu. - Implement host_desktop.cc and plumb a few places that need context to determine which style of desktop it belongs to. - Remove --desktop-aura, --open-ash, --enable-ash TBR=jam@chromium.org BUG=133312 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=163414

Patch Set 1 : remove unrelated change #

Total comments: 2

Patch Set 2 : force transparent windows on cros for now #

Patch Set 3 : try rebase again #

Patch Set 4 : no idea what's going on #

Patch Set 5 : try again #

Patch Set 6 : wat #

Patch Set 7 : test fixes #

Patch Set 8 : fix android #

Patch Set 9 : fix gtk #

Patch Set 10 : . #

Patch Set 11 : fix non-use_ash builds #

Patch Set 12 : cleanup in tests #

Patch Set 13 : rebase #

Patch Set 14 : sneaky code! in test_views_delegate.cc #

Patch Set 15 : another busted command line flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -99 lines) Patch
M ash/shell.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +1 line, -2 lines 0 comments Download
M chrome/app/chrome_dll.rc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/ash_util.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +14 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/host_desktop.h View 2 chunks +23 lines, -5 lines 0 comments Download
A chrome/browser/ui/host_desktop.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +72 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame_aura.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -10 lines 0 comments Download
M content/shell/shell_aura.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/screen.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/screen.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +6 lines, -0 lines 0 comments Download
M ui/gfx/screen_type_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/views_switches.h View 1 chunk +0 lines, -19 lines 0 comments Download
D ui/views/views_switches.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
scottmg
8 years, 2 months ago (2012-10-17 22:51:15 UTC) #1
Ben Goodger (Google)
lgtm https://codereview.chromium.org/11146023/diff/2031/chrome/browser/ui/views/chrome_views_delegate.cc File chrome/browser/ui/views/chrome_views_delegate.cc (right): https://codereview.chromium.org/11146023/diff/2031/chrome/browser/ui/views/chrome_views_delegate.cc#newcode151 chrome/browser/ui/views/chrome_views_delegate.cc:151: return false; I suspect this function needs to ...
8 years, 2 months ago (2012-10-17 23:21:27 UTC) #2
scottmg
https://codereview.chromium.org/11146023/diff/2031/chrome/browser/ui/views/chrome_views_delegate.cc File chrome/browser/ui/views/chrome_views_delegate.cc (right): https://codereview.chromium.org/11146023/diff/2031/chrome/browser/ui/views/chrome_views_delegate.cc#newcode151 chrome/browser/ui/views/chrome_views_delegate.cc:151: return false; On 2012/10/17 23:21:27, Ben Goodger (Google) wrote: ...
8 years, 2 months ago (2012-10-17 23:39:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11146023/8105
8 years, 2 months ago (2012-10-19 15:42:31 UTC) #4
commit-bot: I haz the power
Presubmit check for 11146023-8105 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-19 15:42:47 UTC) #5
scottmg
tbr jam for content/shell/shell_aura.cc
8 years, 2 months ago (2012-10-19 15:45:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11146023/8105
8 years, 2 months ago (2012-10-19 15:45:46 UTC) #7
jam
lgtm
8 years, 2 months ago (2012-10-19 16:10:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11146023/30002
8 years, 2 months ago (2012-10-19 17:52:09 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-19 18:52:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11146023/30002
8 years, 2 months ago (2012-10-19 21:05:53 UTC) #11
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests
8 years, 2 months ago (2012-10-19 22:29:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11146023/11089
8 years, 2 months ago (2012-10-22 19:04:27 UTC) #13
commit-bot: I haz the power
8 years, 2 months ago (2012-10-22 22:35:40 UTC) #14 
Change committed as 163414

Powered by Google App Engine
This is Rietveld 408576698