Remove the run verb on Windows 8.

chrome/installer/util/shell_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines functions that integrate Chrome in Windows shell. These
 // functions can be used by Chrome as well as Chrome installer. All of the
 // work is done by the local functions defined in anonymous namespace in
 // this class.
 
 #include "chrome/installer/util/shell_util.h"
@@ skipping 221 matching lines @@
     // DelegateExecute ProgId. Needed for Chrome Metro in Windows 8.
     if (set_delegate_execute) {
       string16 model_id_shell(ShellUtil::kRegClasses);
       model_id_shell.push_back(FilePath::kSeparators[0]);
       model_id_shell.append(app_id);
       model_id_shell.append(ShellUtil::kRegExePath);
       model_id_shell.append(ShellUtil::kRegShellPath);
 
       // <root hkey>\Software\Classes\<app_id>\.exe\shell @=open
       entries->push_back(new RegistryEntry(model_id_shell,
-                                          ShellUtil::kRegVerbOpen));
+                                           ShellUtil::kRegVerbOpen));
 
       const wchar_t* const verbs[] = { ShellUtil::kRegVerbOpen,
-                                       ShellUtil::kRegVerbOpenNewWindow,
-                                       ShellUtil::kRegVerbRun };
+                                       ShellUtil::kRegVerbOpenNewWindow };
       for (size_t i = 0; i < arraysize(verbs); ++i) {
         string16 sub_path(model_id_shell);
         sub_path.push_back(FilePath::kSeparators[0]);
         sub_path.append(verbs[i]);
 
         // <root hkey>\Software\Classes\<app_id>\.exe\shell\<verb>
         entries->push_back(new RegistryEntry(
             sub_path, L"CommandId", L"Browser.Launch"));
 
         sub_path.push_back(FilePath::kSeparators[0]);
@@ skipping 751 matching lines @@
     shortcut_properties.set_app_id(
         ShellUtil::GetBrowserModelId(dist, is_per_user_install));
   }
 
   if (properties.has_dual_mode())
     shortcut_properties.set_dual_mode(properties.dual_mode);
 
   return shortcut_properties;
 }
 
+// Cleans up an old verb (run) we used to register in
+// <root>\Software\Classes\Chrome<.suffix>\.exe\shell\run.
+// TODO (gab): This was fixed before the official release of Windows 8 and thus

[grt (UTC plus 2), 2012/10/16 01:43:03]

"official release" -> "general availability"

[gab, 2012/10/16 14:59:50]

Done.

+// can safely be removed in February 2013.
+void RemoveRunVerbOnWindows8(
+    BrowserDistribution* dist,
+    const string16& chrome_exe) {
+  HKEY root_key = DetermineShellIntegrationRoot(

[grt (UTC plus 2), 2012/10/16 01:43:03]

wrap this function in:
if (IsChromeMetroSupported()) {
  ...
}?

[grt (UTC plus 2), 2012/10/16 01:43:03]

is root_key always HKCU?

[gab, 2012/10/16 14:59:50]

Done.

[gab, 2012/10/16 14:59:50]

HKCU on user-level installs, HKLM on system-level installs. Just figured I'd
re-use this method instead of hardcoding this fact.

[grt (UTC plus 2), 2012/10/16 15:31:13]

Oh yeah.  Good call.

+      InstallUtil::IsPerUserInstall(chrome_exe.c_str()));

[grt (UTC plus 2), 2012/10/16 01:43:03]

store the value of IsPerUserInstall() and re-use on line 1031.

[gab, 2012/10/16 14:59:50]

Indeed! Done.

+  // There's no need to rollback, so forgo the usual work item lists and just
+  // remove the key from the registry.
+  string16 run_verb_key(ShellUtil::kRegClasses);
+  run_verb_key.push_back(FilePath::kSeparators[0]);
+  run_verb_key.append(ShellUtil::GetBrowserModelId(
+      dist, InstallUtil::IsPerUserInstall(chrome_exe.c_str())));
+  run_verb_key.append(ShellUtil::kRegExePath);
+  run_verb_key.append(ShellUtil::kRegShellPath);
+  run_verb_key.push_back(FilePath::kSeparators[0]);
+  run_verb_key.append(ShellUtil::kRegVerbRun);
+  InstallUtil::DeleteRegistryKey(root_key, run_verb_key);
+}
+
 }  // namespace
 
 const wchar_t* ShellUtil::kRegDefaultIcon = L"\\DefaultIcon";
 const wchar_t* ShellUtil::kRegShellPath = L"\\shell";
 const wchar_t* ShellUtil::kRegShellOpen = L"\\shell\\open\\command";
 const wchar_t* ShellUtil::kRegStartMenuInternet =
     L"Software\\Clients\\StartMenuInternet";
 const wchar_t* ShellUtil::kRegClasses = L"Software\\Classes";
 const wchar_t* ShellUtil::kRegRegisteredApplications =
     L"Software\\RegisteredApplications";
@@ skipping 484 matching lines @@
   string16 suffix;
   if (!unique_suffix.empty()) {
     suffix = unique_suffix;
   } else if (!GetInstallationSpecificSuffix(dist, chrome_exe, &suffix)) {
     return false;
   }
 
   // TODO(grt): remove this on or after 2012-08-01; see impl for details.
   RemoveBadWindows8RegistrationIfNeeded(dist, chrome_exe);
 
+  // TODO(gab): remove this on or after 2013-02-01; see impl for details.
+  RemoveRunVerbOnWindows8(dist, chrome_exe);
+
   // Check if Chromium is already registered with this suffix.
   if (IsChromeRegistered(dist, chrome_exe, suffix))
     return true;
 
   bool user_level = InstallUtil::IsPerUserInstall(chrome_exe.c_str());
   HKEY root = DetermineShellIntegrationRoot(user_level);
 
   // Do the full registration if we can do it at user-level or if the user is an
   // admin.
   if (root == HKEY_CURRENT_USER || IsUserAnAdmin()) {
@@ skipping 206 matching lines @@
     // are any left...).
     if (free_bits >= 8 && next_byte_index < size) {
       free_bits -= 8;
       bit_stream += bytes[next_byte_index++] << free_bits;
     }
   }
 
   DCHECK_EQ(ret.length(), encoded_length);
   return ret;
 }