src/x64/codegen-x64.cc - Issue 1114001: Refactoring of RegExp interface to better support calling several times in a row.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/codegen-x64.cc

Issue 1114001: Refactoring of RegExp interface to better support calling several times in a row. (Closed)

Patch Set: Fix type that snuck into the commit. Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/codegen-x64.cc

diff --git a/src/x64/codegen-x64.cc b/src/x64/codegen-x64.cc

index 8ec1c9505a1942d3930bbe1422b713be341c8dec..d2130a1a481fdf32c04e8e2bbf383648ffe9b0bf 100644

--- a/src/x64/codegen-x64.cc

+++ b/src/x64/codegen-x64.cc

@@ -7182,12 +7182,6 @@ void RegExpExecStub::Generate(MacroAssembler* masm) {

// Read the value from the static offsets vector buffer and make it a smi.

__ movl(rdi, Operand(rcx, rdx, times_int_size, 0));

__ Integer32ToSmi(rdi, rdi, &runtime);

- // Add previous index (from its stack slot) if value is not negative.

- Label capture_negative;

- // Negative flag set by smi convertion above.

- __ j(negative, &capture_negative);

- __ SmiAdd(rdi, rdi, rax, &runtime); // Add previous index.

- __ bind(&capture_negative);

// Store the smi value in the last match info.

__ movq(FieldOperand(rbx,

rdx,