Move "default for protocol" probing logic out of shell_integration_win.cc into shell_util.cc.

chrome/installer/util/shell_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares methods that are useful for integrating Chrome in
 // Windows shell. These methods are all static and currently part of
 // ShellUtil class.
 
 #ifndef CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
 #define CHROME_INSTALLER_UTIL_SHELL_UTIL_H_
@@ skipping 14 matching lines @@
 // This is a utility class that provides common shell integration methods
 // that can be used by installer as well as Chrome.
 class ShellUtil {
  public:
   // Input to any methods that make changes to OS shell.
   enum ShellChange {
     CURRENT_USER = 0x1,  // Make any shell changes only at the user level
     SYSTEM_LEVEL = 0x2   // Make any shell changes only at the system level
   };
 
+  // Chrome's default handler state for a given protocol.
+  enum DefaultState {
+    NOT_DEFAULT = 0,

[grt (UTC plus 2), 2012/10/12 19:59:35]

nit: remove " = 0"

[gab, 2012/10/12 20:35:12]

This mimics the enum defined in shell_integration.h, I'd rather keep them as
similar as possible.

[grt (UTC plus 2), 2012/10/15 13:44:33]

I don't think this is necessary since they're independent types (see
GetDefaultWebClientStateFromShellUtilDefaultState).  If you intend for them to
be identical, I suggest you document this with a comment and enforce it with
COMPILE_ASSERT.

[gab, 2012/10/15 14:20:39]

Done.

+    IS_DEFAULT,
+    UNKNOWN_DEFAULT = -1

[grt (UTC plus 2), 2012/10/12 19:59:35]

does this need to be -1?  why not 2?

[gab, 2012/10/12 20:35:12]

Same justification as above.

[grt (UTC plus 2), 2012/10/15 13:44:33]

Would you at least move this above NOT_DEFAULT and get rid of the " = 0" there? 
It's nonsensical to me to have the values out of order like this.

[gab, 2012/10/15 14:20:39]

Done.

+  };
+
   // Typical shortcut directories. Resolved in GetShortcutPath().
   enum ChromeShortcutLocation {
     SHORTCUT_DESKTOP,
     SHORTCUT_QUICK_LAUNCH,
     SHORTCUT_START_MENU,
   };
 
   enum ChromeShortcutOperation {
     // Create a new shortcut (overwriting if necessary).
     SHORTCUT_CREATE_ALWAYS,
@@ skipping 327 matching lines @@
   // The returned appid is guaranteed to be no longer than
   // chrome::kMaxAppModelIdLength (some of the components might have been
   // shortened to enforce this).
   static string16 BuildAppModelId(const std::vector<string16>& components);
 
   // Returns true if Chrome can make itself the default browser without relying
   // on the Windows shell to prompt the user. This is the case for versions of
   // Windows prior to Windows 8.
   static bool CanMakeChromeDefaultUnattended();
 
+  // Returns true if Chrome is the default handler for HTTP and HTTPS.
+  static DefaultState IsChromeDefault();
+
+  // Returns true if Chrome is the default handler for |protocol|.
+  static DefaultState IsChromeDefaultProtocolClient(const string16& protocol);
+
   // Make Chrome the default browser. This function works by going through
   // the url protocols and file associations that are related to general
   // browsing, e.g. http, https, .html etc., and requesting to become the
   // default handler for each. If any of these fails the operation will return
   // false to indicate failure, which is consistent with the return value of
   // ShellIntegration::IsDefaultBrowser.
   //
   // In the case of failure any successful changes will be left, however no
   // more changes will be attempted.
   // TODO(benwells): Attempt to undo any changes that were successfully made.
@@ skipping 138 matching lines @@
   // required by the base32 standard for inputs that aren't a multiple of 5
   // bytes.
   static string16 ByteArrayToBase32(const uint8* bytes, size_t size);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ShellUtil);
 };
 
 
 #endif  // CHROME_INSTALLER_UTIL_SHELL_UTIL_H_