Pass the client end handle of the network-to-daemon IPC channel via handle inheritance.

remoting/host/win/unprivileged_process_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file implements the Windows service controlling Me2Me host processes
 // running within user sessions.
 
 #include "remoting/host/win/unprivileged_process_delegate.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
+#include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/scoped_handle.h"
+#include "ipc/ipc_channel_proxy.h"
+#include "ipc/ipc_message.h"
 #include "remoting/host/win/launch_process_with_token.h"
 
 using base::win::ScopedHandle;
 
 namespace {
 
-// The command line switch specifying the name of the daemon IPC endpoint.
-const char kDaemonIpcSwitchName[] = "daemon-pipe";
+// Match the pipe name prefix used by Chrome IPC channels so that the client
+// could use Chrome IPC APIs instead of connecting manually.

[simonmorris, 2012/10/12 16:31:13]

Both of these constants appear in more than one file. They should probably be
factored out.

[alexeypa (please no reviews), 2012/10/12 18:44:39]

Done.

+const char kChromePipeNamePrefix[] = "\\\\.\\pipe\\chrome.";
+
+// The command line switches specifying the daemon IPC endpoint.

[simonmorris, 2012/10/12 16:31:13]

switches -> switch?

[alexeypa (please no reviews), 2012/10/12 18:44:39]

Done.

+const char kDaemonPipeSwitchName[] = "daemon-pipe";
+
+// The security descriptor of the daemon IPC endpoint. It gives full access
+// to LocalSystem and denies access by anyone else.
+const char kDaemonIpcSecurityDescriptor[] = "O:SYG:SYD:(A;;GA;;;SY)";
 
 // The command line parameters that should be copied from the service's command
 // line to the host process.
 const char* kCopiedSwitchNames[] = {
     "host-config", switches::kV, switches::kVModule };
 
 } // namespace
 
 namespace remoting {
 
 UnprivilegedProcessDelegate::UnprivilegedProcessDelegate(
     scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
     const FilePath& binary_path)
     : main_task_runner_(main_task_runner),
       io_task_runner_(io_task_runner),
       binary_path_(binary_path) {
 }
 
 UnprivilegedProcessDelegate::~UnprivilegedProcessDelegate() {
   KillProcess(CONTROL_C_EXIT);
 }
 
+bool UnprivilegedProcessDelegate::Send(IPC::Message* message) {
+  DCHECK(main_task_runner_->BelongsToCurrentThread());
+
+  return channel_->Send(message);
+}
+
 DWORD UnprivilegedProcessDelegate::GetExitCode() {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
   DWORD exit_code = CONTROL_C_EXIT;
   if (worker_process_.IsValid()) {
     if (!::GetExitCodeProcess(worker_process_, &exit_code)) {
       LOG_GETLASTERROR(INFO)
           << "Failed to query the exit code of the worker process";
       exit_code = CONTROL_C_EXIT;
     }
   }
 
   return exit_code;
 }
 
 void UnprivilegedProcessDelegate::KillProcess(DWORD exit_code) {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
 
+  channel_.reset();
+
   if (worker_process_.IsValid()) {
     TerminateProcess(worker_process_, exit_code);
   }
 }
 
 bool UnprivilegedProcessDelegate::LaunchProcess(
-    const std::string& channel_name,
+    IPC::Listener* delegate,
     ScopedHandle* process_exit_event_out) {
   DCHECK(main_task_runner_->BelongsToCurrentThread());
+  // Generate a unique name of the channel.

[simonmorris, 2012/10/12 16:31:13]

of -> for

[alexeypa (please no reviews), 2012/10/12 18:44:39]

Done.

+  std::string channel_name = GenerateIpcChannelName(this);
+
+  // Create a connected IPC channel.
+  ScopedHandle client;
+  scoped_ptr<IPC::ChannelProxy> server;
+  if (!CreateConnectedIpcChannel(channel_name, delegate, &client, &server))
+    return false;
+
+  // Convert the handle value into a decimal integer. Handle values are 32bit
+  // even on 64bit platforms.
+  std::string pipe_handle = base::StringPrintf(
+      "%d", reinterpret_cast<ULONG_PTR>(client.Get()));
 
   // Create the command line passing the name of the IPC channel to use and
   // copying known switches from the caller's command line.
   CommandLine command_line(binary_path_);
-  command_line.AppendSwitchNative(kDaemonIpcSwitchName,
-                                  UTF8ToWide(channel_name));
+  command_line.AppendSwitchASCII(kDaemonPipeSwitchName, pipe_handle);
   command_line.CopySwitchesFrom(*CommandLine::ForCurrentProcess(),
                                 kCopiedSwitchNames,
                                 arraysize(kCopiedSwitchNames));
 
   // Try to launch the process.
   // TODO(alexeypa): Pass a restricted process token.
   // See http://crbug.com/134694.
   ScopedHandle worker_thread;
   worker_process_.Close();
   if (!LaunchProcessWithToken(command_line.GetProgram(),
                               command_line.GetCommandLineString(),
                               NULL,
+                              true,
                               0,
                               &worker_process_,
                               &worker_thread)) {
     return false;
   }
 
   // Return a handle that the caller can wait on to get notified when
   // the process terminates.
   ScopedHandle process_exit_event;
   if (!DuplicateHandle(GetCurrentProcess(),
                        worker_process_,
                        GetCurrentProcess(),
                        process_exit_event.Receive(),
                        SYNCHRONIZE,
                        FALSE,
                        0)) {
     LOG_GETLASTERROR(ERROR) << "Failed to duplicate a handle";
     KillProcess(CONTROL_C_EXIT);
     return false;
   }
 
+  channel_ = server.Pass();
   *process_exit_event_out = process_exit_event.Pass();
   return true;
 }
 
+bool UnprivilegedProcessDelegate::CreateConnectedIpcChannel(
+    std::string channel_name,

[simonmorris, 2012/10/12 16:31:13]

std::string -> const std::string& ?

[alexeypa (please no reviews), 2012/10/12 18:44:39]

Done.

+    IPC::Listener* delegate,
+    ScopedHandle* client_out,
+    scoped_ptr<IPC::ChannelProxy>* server_out) {
+  // Create the server end of the channel.
+  scoped_ptr<IPC::ChannelProxy> server;
+  if (!CreateIpcChannel(channel_name, kDaemonIpcSecurityDescriptor,
+                        io_task_runner_, delegate, &server)) {
+    return false;
+  }
+
+  // Convert the channel name to the pipe name.
+  std::string pipe_name(kChromePipeNamePrefix);
+  pipe_name.append(channel_name);
+
+  // Create the client end of the channel. This code should match the code in
+  // IPC::Channel.
+  ScopedHandle client;
+  SECURITY_ATTRIBUTES security_attributes = { sizeof(security_attributes), NULL,
+                                              TRUE };

[simonmorris, 2012/10/12 16:31:13]

This seems an unnecessarily opaque way to initialise |security_attributes|.

[alexeypa (please no reviews), 2012/10/12 18:44:39]

Done.

+  client.Set(CreateFile(UTF8ToUTF16(pipe_name).c_str(),
+                        GENERIC_READ | GENERIC_WRITE,
+                        0,
+                        &security_attributes,
+                        OPEN_EXISTING,
+                        SECURITY_SQOS_PRESENT | SECURITY_IDENTIFICATION |
+                            FILE_FLAG_OVERLAPPED,
+                        NULL));
+  if (!client.IsValid())
+    return false;
+
+  *client_out = client.Pass();
+  *server_out = server.Pass();
+  return true;
+}
+
 } // namespace remoting