Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/extensions/platform_app_browsertest_util.h

Issue 11117011: Keep browser process alive while there are platform apps with background pages running. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: And another test Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/platform_app_browsertest_util.h
diff --git a/chrome/browser/extensions/platform_app_browsertest_util.h b/chrome/browser/extensions/platform_app_browsertest_util.h
index 3d3a2a7d40efd36e9d4d74b9e443b0147b72f2b3..88c92580e512668e455d290efcdce0b6f690e622 100644
--- a/chrome/browser/extensions/platform_app_browsertest_util.h
+++ b/chrome/browser/extensions/platform_app_browsertest_util.h
@@ -19,11 +19,23 @@ class ShellWindow;
namespace extensions {
class Extension;
+// TODO(benwells): Clean up this test hierarchy.
+// - rename this to PlatformAppApiTest
+// - remove the existing PlatformAppApiTest
+// - Move the CloseWindow* functions from ExtensionBrowserTest to here
+// - Move the RunPlatformAppTest functions from ExtensionApiTest to here
+// - Make all platform app tests use this class.
class PlatformAppBrowserTest : public ExtensionApiTest {
public:
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE;
protected:
+ // Loads the app named |name| out of the platform_apps subdirectory.
+ const Extension* LoadPlatformApp(const char* name);
+
+ // Installs the app named |name| out of the platform_apps subdirectory.
+ const Extension* InstallPlatformApp(const char* name);
+
// Runs the app named |name| out of the platform_apps subdirectory. Waits
// until it is launched.
const Extension* LoadAndLaunchPlatformApp(const char* name);
@@ -63,9 +75,6 @@ class PlatformAppBrowserTest : public ExtensionApiTest {
// Creates an empty shell window for |extension|.
ShellWindow* CreateShellWindow(const Extension* extension);
-
- // Closes |window| and waits until it's gone.
- void CloseShellWindow(ShellWindow* window);
};
}
« no previous file with comments | « chrome/browser/extensions/platform_app_browsertest.cc ('k') | chrome/browser/extensions/platform_app_browsertest_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698